Wait for Postgres to become available instead of naively sleeping before running Alembic migrations#126
Open
jaredtkatz wants to merge 4 commits intoBuuntu:masterfrom
Open
Wait for Postgres to become available instead of naively sleeping before running Alembic migrations#126jaredtkatz wants to merge 4 commits intoBuuntu:masterfrom
jaredtkatz wants to merge 4 commits intoBuuntu:masterfrom
Conversation
Owner
|
I'd rather the wait for it script be copied into the scripts directory than maintaining it as a submodule personally. That script is made to be copy+pasted anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for the
postgresDocker Compose service to become available instead of naively sleeping for 5 seconds before running Alembic migrations. Implemented using the popularwait-for-it.shscript (added to the repo as a git submodule).