Skip to content

Feature: Traceroute - World Map / Visual Routing#3520

Open
BornToBeRoot wants to merge 1 commit into
mainfrom
feature/visual_traceroute
Open

Feature: Traceroute - World Map / Visual Routing#3520
BornToBeRoot wants to merge 1 commit into
mainfrom
feature/visual_traceroute

Conversation

@BornToBeRoot

Copy link
Copy Markdown
Owner

Changes proposed in this pull request

  • Add world map with routing details

Related issue(s)

To-Do

Contributing

By submitting this pull request, I confirm the following:

@mergify

mergify Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an offline “visual traceroute” world map to the Traceroute tool, rendering hop geolocations and hop-to-hop direction arrows with pan/zoom support, and exposes an app setting for default expansion of the map panel.

Changes:

  • Adds a new TracerouteMapView WPF control that draws an embedded vector world map with hop markers, arrows, and an info panel.
  • Updates TracerouteView layout to host the map under the hop grid with an expander + row splitter, including persistence of the default expanded/collapsed state via settings.
  • Adds embedded map resources (cities/country outlines), a generation script, and attribution in the resource documentation list.

Reviewed changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Source/NETworkManager/Views/TracerouteView.xaml.cs Adds expander/collapse logic to preserve map row height and free space when collapsed.
Source/NETworkManager/Views/TracerouteView.xaml Reworks layout to include a resizable, collapsible map panel under traceroute results.
Source/NETworkManager/Views/TracerouteSettingsView.xaml Adds a UI toggle for the “Expand map view” setting.
Source/NETworkManager/Views/TracerouteMapView.xaml.cs Implements the new map control: drawing, decluttering, zoom/pan, hop grouping, and hover info.
Source/NETworkManager/Views/TracerouteMapView.xaml Defines the map control UI (canvas layers, info panel, reset button).
Source/NETworkManager/Views/TracerouteMapView.HANDOFF.md Adds an implementation handoff note (review flagged as should not ship).
Source/NETworkManager/ViewModels/TracerouteViewModel.cs Introduces ExpandMapView and loads it from settings.
Source/NETworkManager/ViewModels/TracerouteSettingsViewModel.cs Persists ExpandMapView to settings from the settings UI.
Source/NETworkManager/Resources/Styles/GridSplitterStyles.xaml Adds HorizontalGridSplitter style for row resizing.
Source/NETworkManager/Resources/Maps/world-cities.json Adds embedded city reference data for the offline map.
Source/NETworkManager/NETworkManager.csproj Embeds the map JSON files as resources in the main app assembly.
Source/NETworkManager.Settings/SettingsInfo.cs Adds Traceroute_ExpandMapView setting property.
Source/NETworkManager.Settings/GlobalStaticConfiguration.cs Adds default value for Traceroute_ExpandMapView.
Source/NETworkManager.Localization/Resources/Strings.resx Adds localized keys for “Map”, “Expand map view”, and Natural Earth attribution.
Source/NETworkManager.Localization/Resources/Strings.Designer.cs Adds strongly-typed accessors for the new localization keys.
Source/NETworkManager.Documentation/ResourceManager.cs Adds Natural Earth GeoJSON source attribution entry.
Scripts/Create-WorldMapFromWeb.ps1 Adds script to generate the embedded map/cities JSON from Natural Earth sources.
Files not reviewed (1)
  • Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Source/NETworkManager/Views/TracerouteMapView.xaml
Comment thread Source/NETworkManager/Views/TracerouteMapView.xaml.cs
Comment thread Source/NETworkManager/ViewModels/TracerouteViewModel.cs
Comment thread Source/NETworkManager/Views/TracerouteMapView.HANDOFF.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants