feat: add warnings and specifically unused variable warnings#246
Open
stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
Open
feat: add warnings and specifically unused variable warnings#246stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds warnings, taken originally from #232, by themselves, without the extra clutter of
infixoperators.However, I did want to add an unused variable warning.
A particularly dangerous case is where the developer uses an
add_Njet, but doesn't do anything with thecarry, allowing silent overflows.With this PR the warning is added:
I also added scripts to run all the examples to see if they still compile. If this bugs anyone, I'm happy to remove it.