Fix aerobic polishing oxygen deficit handling (#240)#242
Conversation
Merge `master` chnages into `qsdsan` branch
|
Thanks for the updates! I added a few more assertions to account for mass and atomic balances. It seems like the mass balance error is not negligible (about 0.6% more comes out than what comes in). Could you have a look to see where might this issue come from? Also, the atomic balance is a slightly off. If the unit is not meant to account for the atomic balance (understandably because of the bulk sludge component), please feel free to remove the atomic balance test. You can use "pull origin qsdsan" to update your local repo with my changes. Thanks! |
Consumed O2 was being re-added to air_out after already being accounted for in combustion products, causing ~0.6% mass balance error. Remove the erroneous air_out O2 line and drop the atomic balance assertion (elemental imbalance is inherent to the bulk WWTsludge approximation). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@yoelcortes the bug should be fixed now, O2 was double-counted, I also removed the atomic balance check since it wasn't expected to be balanced. |
yoelcortes
left a comment
yoelcortes
left a comment
There was a problem hiding this comment.
Everything looks good now! Thanks!
2 participants
@yoelcortes
See issue #240 for details, with these implementations, the original codes should run (i.e., users don't need to lock gases at gas phase).