fix(app) fix PlatformException crash when exporting device diagnostics#8057
Open
krushnarout wants to merge 1 commit into
Open
fix(app) fix PlatformException crash when exporting device diagnostics#8057krushnarout wants to merge 1 commit into
krushnarout wants to merge 1 commit into
Conversation
ShareParams was missing a title, causing share_plus to throw Non-empty title expected on iOS Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShareParamsin_exportDiagnosticswas missing atitle, causingshare_plusto throwPlatformException(error, Non-empty title expected, null, null)on iOS every time a user tapped the export button on the Device Diagnostics screen.title: 'Omi Device Diagnostics'alongside the existingsubject.Crash
Crashlytics: https://console.firebase.google.com/u/0/project/based-hardware/crashlytics/app/ios:com.friend-app-with-wearable.ios12/issues/40d960fea757d7ea8a9d0c02bec36346
Test plan
🤖 Generated with Claude Code