Harden OCE report skill against dim-pct name-column starvation, Fixes AB#3678009#440
Merged
Merged
Conversation
When a dim-pct cell carried a WoW annotation (e.g. '75% (+111%)') it starved the flex name column and truncated real labels to '1...'. Three-layer fix:
- report-template.html: .dim-pct now flex:0 1 auto + max-width:72px + ellipsis so a long value truncates itself instead of the name.
- validate-report.ps1: new check 9c fails the build on any dim-pct containing '(' or > 9 chars.
- spike-card.html: document the bare-percentage dim-pct rule.
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
shahzaibj
approved these changes
Jun 26, 2026
github-actions
Bot
changed the title
|
✅ Work item link check complete. Description contains link AB#3678009 to an Azure Boards work item. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the oncall-weekly-telemetry-report skill, a Spike Attribution
dim-pctcell that carried a WoW annotation (e.g.75% (+111%)) sat in the narrow, fixed percent column and starved the flex name column, collapsing real labels to a couple of characters — broker version16.1.0rendered as1...,KeyPairGenerationasKeyPai.... The existing layout guards (checks 9a/9b) only assert the CSS exists; they couldn''t catch this content-level authoring mistake.This adds a three-layer defense so it can''t recur.
Changes
assets/templates/report-template.html):.dim-pctchanged fromflex: 0 0 autotoflex: 0 1 autowithmax-width: 72px+overflow:hidden; text-overflow:ellipsis. A stray long value now truncates itself instead of the name.assets/scripts/validate-report.ps1): new check 9c fails the build if anydim-pctcell contains(or exceeds 9 characters. Also listed in the validator header doc.assets/templates/spike-card.html): documents thatdim-pctis a short bare percentage only; WoW deltas go in prose / tags / Caller hot-spots.Validation
validate-report.ps1passes all hard checks, including the new[OK] dim-pct cells are short bare percentages.75% (+111%)is flagged while50.7%,+759%,100.0%pass clean.visual-smoke.ps1: 0 overflow / 0 adjacent-gap issues.No functional report content changed — skill-hardening only.
Work item: AB#3678009