Enable containerd device ownership from security context - #548
Open
Patrick W. Healy (phealy) wants to merge 3 commits into
Open
Enable containerd device ownership from security context#548Patrick W. Healy (phealy) wants to merge 3 commits into
Patrick W. Healy (phealy) wants to merge 3 commits into
Conversation
Enable containerd to derive mapped device ownership from the pod security context so non-root workloads retain access to devices such as KVM. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f55fcca7-1344-4ce2-8f86-06e677157287
Patrick W. Healy (phealy)
requested review from
a team
and
a lite review from Copilot
July 27, 2026 12:29
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure containerd preserves access to mapped host devices (e.g., /dev/kvm) for non-root pods by enabling containerd’s device ownership behavior derived from the Kubernetes security context, and adds a regression test to validate the generated containerd config.
Changes:
- Enable
device_ownership_from_security_contextin the generated containerd configuration template. - Add a regression test asserting the generated config includes the intended setting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/agent/phases/nodestart/assets/containerd.toml | Updates the containerd config template to enable device ownership from security context. |
| pkg/agent/phases/nodestart/cri_test.go | Adds a regression test that validates the generated containerd config contains the new setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hbc (bcho)
previously approved these changes
Jul 27, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7b5e2080-53bb-4e91-93b1-56dac5f0e214
hbc (bcho)
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
device_ownership_from_security_contextin the containerd CRI runtime configurationDocumentation
Testing
go test ./pkg/agent/phases/nodestart