-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix traced HttpResponseError for identity-based datastores #44650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
- Check if datastore uses NoneCredentialConfiguration before calling _list_secrets() - Avoid unnecessary exception that gets captured by OpenTelemetry tracing - Add unit tests for get_datastore_info with different credential types Co-authored-by: mohammadsheraj <221899694+mohammadsheraj@users.noreply.github.com>
Co-authored-by: mohammadsheraj <221899694+mohammadsheraj@users.noreply.github.com>
|
hey @mohammadsheraj thanks for picking this up! will copilot get back to complete this PR? 😇 |
Adding the current DRI @PratibhaShrivastav18 |
|
so close 😢 |
|
Sorry I did not mean to close the issue. Reopened. |
|
look almost there. thank you for pushing this :) sorry for nagging |
get_datastore_info()unconditionally calls_list_secrets(), which raisesHttpResponseErrorfor identity-based datastores. While caught and handled, OpenTelemetry captures these exceptions as error traces in Application Insights.Changes:
_list_secrets()to avoid exception for identity-based datastoresNoneCredentialConfigurationBefore:
After:
Unit tests added for identity-based, SAS token, and account key credentials.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
pypi.org/home/REDACTED/work/azure-sdk-for-python/azure-sdk-for-python/.venv/bin/pip pip install pytest-mock -q ests/finetuning_job/e2e_tests/test_maap_finetuning_job.py ests/finetuning_job/unittests/test_azure_openai_finetuning_job_schema.py ests/finetuning_job/unittests/test_finetuning_job_convesion.py ests/finetuning_job/unittests/test_custom_model_finetuning_job_schema.py ests/finetuning_job/conftest.py ests/environment/e2etests/test_environment.py ests/environment/unittests/test_env_entity.py ests/environment/unittests/test_environment_operations.py ests�� ests/environment/unittests/test_environment_operations_registry.py ests/model/e2etests/test_model.py(dns block)scanning-api.github.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.