Skip to content

App Config to TypeSpec#49272

Merged
mrm9084 merged 14 commits into
Azure:mainfrom
mrm9084:MoveToTypeSpec
Jun 2, 2026
Merged

App Config to TypeSpec#49272
mrm9084 merged 14 commits into
Azure:mainfrom
mrm9084:MoveToTypeSpec

Conversation

@mrm9084
Copy link
Copy Markdown
Member

@mrm9084 mrm9084 commented May 26, 2026

Description

This should be an in place update from swagger to typespec.

Copilot AI review requested due to automatic review settings May 26, 2026 22:02
@mrm9084 mrm9084 requested review from a team, alzimmermsft, avanigupta and nroutray as code owners May 26, 2026 22:02
@github-actions github-actions Bot added the App Configuration Azure.ApplicationModel.Configuration label May 26, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates azure-data-appconfiguration from the legacy Swagger/AutoRest codegen setup to a TypeSpec-based workflow, updating generated implementation surface area while keeping the existing hand-written public clients working via bridging helpers.

Changes:

  • Introduces TypeSpec source mapping (tsp-location.yaml) and removes the old Swagger codegen artifacts/customizations.
  • Updates the hand-written clients to call the new TypeSpec-generated protocol methods via a new internal ImplBridge.
  • Adds/updates TypeSpec-generated implementation models and polling helpers used for snapshot LROs.

Reviewed changes

Copilot reviewed 70 out of 71 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sdk/appconfiguration/azure-data-appconfiguration/tsp-location.yaml Adds TypeSpec spec repo/commit mapping for code generation.
sdk/appconfiguration/azure-data-appconfiguration/swagger/Update-Codegeneration.ps1 Removes legacy Swagger codegen script.
sdk/appconfiguration/azure-data-appconfiguration/swagger/src/main/java/AppConfigCustomization.java Removes legacy Swagger customization class.
sdk/appconfiguration/azure-data-appconfiguration/swagger/README.md Removes legacy AutoRest configuration README.
sdk/appconfiguration/azure-data-appconfiguration/src/test/java/com/azure/data/appconfiguration/implementation/ConfigurationSettingSerializerTest.java Removes tests tied to deleted serialization helper.
sdk/appconfiguration/azure-data-appconfiguration/src/main/resources/META-INF/azure-data-appconfiguration_metadata.json Adds TypeSpec metadata describing generated surface/versioning.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/module-info.java Updates module descriptor to align with regenerated layout.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/package-info.java Replaces rich package docs with generated minimal description.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/Utility.java Reworks snapshot update calls to use protocol-style RequestOptions + BinaryData.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/SyncOperationLocationPollingStrategy.java Adds sync Operation-Location polling strategy helper.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/PollingUtils.java Adds shared polling utilities (retry-after parsing, deserialization helpers).
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/package-info.java Updates implementation package description to TypeSpec-generated wording.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/OperationLocationPollingStrategy.java Adds async Operation-Location polling strategy helper.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/UpdateSnapshotHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/State.java Removes Swagger-generated operation state enum.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/SnapshotUpdateParameters.java Removes Swagger-generated snapshot update body model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/SnapshotStatus.java Adds TypeSpec-generated snapshot status expandable enum.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/SnapshotListResult.java Removes Swagger-generated list result model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/SnapshotFields.java Adds TypeSpec-generated snapshot fields expandable enum.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/Snapshot.java Adds TypeSpec-generated snapshot model used by protocol layer.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/PutLockHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/PutKeyValueHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/package-info.java Updates implementation-models package description to TypeSpec-generated wording.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/OperationState.java Adds TypeSpec-generated operation-state expandable enum.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/OperationDetails.java Updates operation details model for TypeSpec generation.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/LabelListResult.java Removes Swagger-generated list result model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/LabelFields.java Adds TypeSpec-generated label fields expandable enum.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/Label.java Adds TypeSpec-generated label model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/KeyValueListResult.java Removes Swagger-generated list result model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/KeyValueFilter.java Adds TypeSpec-generated key-value filter model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/KeyValueFields.java Adds TypeSpec-generated key-value fields expandable enum.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/KeyValue.java Updates key-value protocol model for TypeSpec generation.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/KeyListResult.java Removes Swagger-generated list result model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/Key.java Updates key protocol model for TypeSpec generation.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/InnerError.java Removes Swagger-generated error model type.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetSnapshotsNextHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetSnapshotsHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetSnapshotHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetRevisionsNextHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetRevisionsHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetLabelsNextHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetLabelsHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetKeyValuesNextHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetKeyValuesHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetKeyValueHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetKeysNextHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/GetKeysHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/ErrorException.java Removes Swagger-generated exception type.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/ErrorDetail.java Removes Swagger-generated error detail model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/Error.java Removes Swagger-generated error model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/DeleteLockHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/DeleteKeyValueHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/CreateSnapshotHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/CompositionType.java Adds TypeSpec-generated composition type expandable enum.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/CheckSnapshotsHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/CheckSnapshotHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/CheckRevisionsHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/CheckLabelsHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/CheckKeyValuesHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/CheckKeyValueHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/models/CheckKeysHeaders.java Removes Swagger-generated response header model.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/ImplBridge.java Adds an internal adapter to preserve the old typed call shapes over protocol-style methods.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/CreateSnapshotUtilClient.java Refactors snapshot LRO helper to use protocol-style requests/responses.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/ConfigurationSettingSerializationHelper.java Removes old custom serialization helper.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/implementation/ConfigurationSettingDeserializationHelper.java Updates error reporting for failed strong-type deserialization.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationClientBuilder.java Updates construction of the TypeSpec-generated implementation client.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationClient.java Switches public sync client implementation to use ImplBridge protocol adapters.
sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationAsyncClient.java Switches public async client implementation to use ImplBridge protocol adapters.
sdk/appconfiguration/azure-data-appconfiguration/customization/src/main/java/AppConfigurationCustomizations.java Adds TypeSpec customization logic to remove/patch generated public surface and adjust impl visibility.
sdk/appconfiguration/azure-data-appconfiguration/customization/pom.xml Renames customization artifact to align with TypeSpec customization module naming.

@mrm9084 mrm9084 enabled auto-merge (squash) June 2, 2026 20:59
@mrm9084 mrm9084 merged commit 330b5c5 into Azure:main Jun 2, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Configuration Azure.ApplicationModel.Configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants