Skip to content

[auto] instructions: add test coverage symmetry rule to Go review guidelines#9139

Draft
richardpark-msft wants to merge 1 commit into
mainfrom
automated/update-instructions-from-pr-reviews
Draft

[auto] instructions: add test coverage symmetry rule to Go review guidelines#9139
richardpark-msft wants to merge 1 commit into
mainfrom
automated/update-instructions-from-pr-reviews

Conversation

@richardpark-msft

Copy link
Copy Markdown
Member

From mining 48 recently-merged PRs, three recurring reviewer themes reached the promotion threshold:

  1. Dead code removal (go.instructions.md) — jongio flagged unused functions/types 3× in feat: ai rle v1 #8782.
  2. CRLF in generated files (extensions.instructions.md) — jongio flagged unconditional \r\n in generated files 3× in feat: ai rle v1 #8782.
  3. URL startsWith bypass (extensions.instructions.md) — richardpark-msft flagged dot-segment path-traversal bypasses 3× in Pull request workflow to check for additional criteria for registry.json changes #9042.

From mining 48 recently-merged PRs, three recurring reviewer themes
reached the promotion threshold:

1. Dead code removal (go.instructions.md) — jongio flagged unused
   functions/types 3× in #8782.
2. CRLF in generated files (extensions.instructions.md) — jongio
   flagged unconditional \\r\\n in generated files 3× in #8782.
3. URL startsWith bypass (extensions.instructions.md) — richardpark-msft
   flagged dot-segment path-traversal bypasses 3× in #9042.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
22 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Hi @@richardpark-msft. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-recent-activity identity issues with no activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant