Skip to content

{Core} Remove deprecated ADAL_PYTHON_SSL_NO_VERIFY environment variable (#33322)#33326

Open
Ketan-33 wants to merge 1 commit intoAzure:devfrom
Ketan-33:cleanup/remove-adal-ssl-no-verify
Open

{Core} Remove deprecated ADAL_PYTHON_SSL_NO_VERIFY environment variable (#33322)#33326
Ketan-33 wants to merge 1 commit intoAzure:devfrom
Ketan-33:cleanup/remove-adal-ssl-no-verify

Conversation

@Ketan-33
Copy link
Copy Markdown

@Ketan-33 Ketan-33 commented May 7, 2026

Related command
N/A – internal core cleanup, no az command affected.

Description
ADAL (Active Directory Authentication Library) was replaced by MSAL.
The ADAL_PYTHON_SSL_NO_VERIFY environment variable was previously used
to disable SSL verification in ADAL, but it no longer has any effect since
the migration. This PR removes the dead constant and the two os.environ
assignments referencing it in _debug.py.

No behavior change — AZURE_CLI_DISABLE_CONNECTION_VERIFICATION remains
the correct way to disable SSL verification.

Closes #33322

Testing Guide

  1. Set AZURE_CLI_DISABLE_CONNECTION_VERIFICATION=1 and run any az command —
    SSL verification should still be disabled as expected.
  2. Verify ADAL_PYTHON_SSL_NO_VERIFY is no longer set in the environment
    during a debug session.

History Notes
{Core} Remove deprecated ADAL_PYTHON_SSL_NO_VERIFY environment variable

Copilot AI review requested due to automatic review settings May 7, 2026 06:54
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 7, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service Bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 7, 2026
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Thank you for your contribution @Ketan-33! We will review the pull request and get back to you soon.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes legacy ADAL-era environment-variable handling from azure-cli-core now that Azure CLI authentication has migrated to MSAL and the ADAL_PYTHON_SSL_NO_VERIFY variable no longer has any functional effect.

Changes:

  • Removed the dead ADAL_PYTHON_SSL_NO_VERIFY constant from azure.cli.core._debug.
  • Removed the two os.environ[...] assignments that attempted to set this deprecated variable when SSL verification is disabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yonzhan yonzhan assigned isra-fel and unassigned jiasli May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

act-platform-engineering-squad Auto-Assign Auto assign by bot Core CLI core infrastructure customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cleanup] Remove legacy ADAL_PYTHON_SSL_NO_VERIFY dead code

5 participants