{Core} Remove deprecated ADAL_PYTHON_SSL_NO_VERIFY environment variable (#33322)#33326
{Core} Remove deprecated ADAL_PYTHON_SSL_NO_VERIFY environment variable (#33322)#33326
Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution @Ketan-33! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
Removes legacy ADAL-era environment-variable handling from azure-cli-core now that Azure CLI authentication has migrated to MSAL and the ADAL_PYTHON_SSL_NO_VERIFY variable no longer has any functional effect.
Changes:
- Removed the dead
ADAL_PYTHON_SSL_NO_VERIFYconstant fromazure.cli.core._debug. - Removed the two
os.environ[...]assignments that attempted to set this deprecated variable when SSL verification is disabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related command
N/A – internal core cleanup, no az command affected.
Description
ADAL (Active Directory Authentication Library) was replaced by MSAL.
The
ADAL_PYTHON_SSL_NO_VERIFYenvironment variable was previously usedto disable SSL verification in ADAL, but it no longer has any effect since
the migration. This PR removes the dead constant and the two
os.environassignments referencing it in
_debug.py.No behavior change —
AZURE_CLI_DISABLE_CONNECTION_VERIFICATIONremainsthe correct way to disable SSL verification.
Closes #33322
Testing Guide
AZURE_CLI_DISABLE_CONNECTION_VERIFICATION=1and run any az command —SSL verification should still be disabled as expected.
ADAL_PYTHON_SSL_NO_VERIFYis no longer set in the environmentduring a debug session.
History Notes
{Core} Remove deprecated ADAL_PYTHON_SSL_NO_VERIFY environment variable