fix: reduce http proxy e2e flakiness#9032
Open
fcher wants to merge 4 commits into
Open
Conversation
fcher
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
karenychen,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
timmy-wright,
titilambert,
xuexu6666 and
zachary-bailey
as code owners
July 23, 2026 23:15
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce E2E flakiness (notably Test_Ubuntu2204_HTTPSProxy_PrivateDNS) by ensuring the in-cluster proxy DaemonSet is only considered “ready” once it is actually accepting TCP connections, rather than immediately upon container start.
Changes:
- Add a TCP readiness probe to the proxy DaemonSet container so
PodReadyreflects the proxy port being reachable. - Add a TCP liveness probe to restart the proxy container if it stops accepting connections.
Comment on lines
+599
to
+604
| // Restart the container if probe fails | ||
| LivenessProbe: &corev1.Probe{ | ||
| ProbeHandler: corev1.ProbeHandler{ | ||
| TCPSocket: &corev1.TCPSocketAction{Port: intstr.FromInt(proxyPort)}, | ||
| }, | ||
| }, |
Contributor
Windows Unit Test Results 3 files 11 suites 44s ⏱️ Results for commit 6dc5c11. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
e2e/kube.go:604
- The readiness/liveness TCP probes rely on default timings (InitialDelaySeconds=0, TimeoutSeconds=1, FailureThreshold=3). With a cold start/image pull or transient scheduling delays, the liveness probe can trigger restarts before the proxy has a chance to bind the port, which may increase (not reduce) e2e flakiness. Set explicit probe timings (especially an initial delay for liveness) tuned for this test DaemonSet.
// Gate readiness on the proxy actually accepting TCP connections on :8888.
ReadinessProbe: &corev1.Probe{
ProbeHandler: corev1.ProbeHandler{
TCPSocket: &corev1.TCPSocketAction{Port: intstr.FromInt(proxyPort)},
},
},
// Restart the container if it stops serving on :8888.
LivenessProbe: &corev1.Probe{
ProbeHandler: corev1.ProbeHandler{
TCPSocket: &corev1.TCPSocketAction{Port: intstr.FromInt(proxyPort)},
},
},
Comment on lines
+648
to
+659
| if len(pods.Items) == 0 { | ||
| lastPodStatuses = []string{"no proxy pods found"} | ||
| } | ||
| // Self-heal once if no proxy pod becomes ready within the grace period | ||
| if !selfHealed && time.Since(start) >= selfHealDelay { | ||
| selfHealed = true | ||
| if rerr := k.recreateProxyPods(ctx); rerr != nil { | ||
| toolkit.Logf(ctx, "failed to recreate proxy pods after %s: %v", selfHealDelay, rerr) | ||
| } else { | ||
| toolkit.Logf(ctx, "recreated proxy pods after %s without a ready proxy", selfHealDelay) | ||
| } | ||
| } |
Also modifies self healing conditionm to handle when at least one proxy pod is available
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
e2e/kube.go:604
- ReadinessProbe also uses Kubernetes defaults, which can make readiness changes slow to reflect and provide less deterministic behavior in tests. Setting explicit probe timing (period/timeout/failureThreshold) will make readiness gating more predictable for the E2E harness.
ReadinessProbe: &corev1.Probe{
ProbeHandler: corev1.ProbeHandler{
TCPSocket: &corev1.TCPSocketAction{Port: intstr.FromInt(proxyPort)},
},
},
e2e/kube.go:610
- LivenessProbe defaults restart the container after ~30s of TCP check failures. For an E2E helper daemonset this can introduce additional churn during transient node/network conditions; consider explicitly increasing the failure budget so the proxy isn’t restarted too aggressively.
LivenessProbe: &corev1.Probe{
ProbeHandler: corev1.ProbeHandler{
TCPSocket: &corev1.TCPSocketAction{Port: intstr.FromInt(proxyPort)},
},
},
Comment on lines
+594
to
+598
| StartupProbe: &corev1.Probe{ | ||
| ProbeHandler: corev1.ProbeHandler{ | ||
| TCPSocket: &corev1.TCPSocketAction{Port: intstr.FromInt(proxyPort)}, | ||
| }, | ||
| }, |
fcher
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes AgentBaker Gate PR flakiness caused by Test_Ubuntu2204_HTTPSProxy_PrivateDNS E2E test
Which issue(s) this PR fixes:
ADO link: https://msazure.visualstudio.com/CloudNativeCompute/_workitems/edit/38383391