Add method signatures to request methods#779
Open
iamliuzy wants to merge 7 commits intoAnswerDotAI:mainfrom
Open
Add method signatures to request methods#779iamliuzy wants to merge 7 commits intoAnswerDotAI:mainfrom
iamliuzy wants to merge 7 commits intoAnswerDotAI:mainfrom
Conversation
To let Pylance stop warning me that these methods doesn't exist.
|
Review these changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/779 |
To avoid method not found error by Pylance due to dynamicly generated methods.
Author
|
@jph00 can you review when conveneint? |
Contributor
|
The current implementation is pretty verbose and clunky. That's a lot of lines of code with a lot of repetition. Let's keep things neat and concise, and seek general solutions over special cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Add method signatures to request methods
about: Add method signatures to request methods
title: 'Add method signatures to request methods'
labels: ''
assignees: 'iamliuzy'
Copy of #756 due to the closing of it.
Related Issue
#319
Proposed Changes
As the title. Add method signatures to request methods.
Although this does nothing at runtime, it provide auto-complete which is helpful.
If these methods have other uses, please let me know.
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply:Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.