Skip to content

Add tests for CLEAR COLUMN IN PARTITION in SummingMergeTree#128

Merged
CarlosFelipeOR merged 5 commits into
mainfrom
new_summing_merge_tree_test
May 27, 2026
Merged

Add tests for CLEAR COLUMN IN PARTITION in SummingMergeTree#128
CarlosFelipeOR merged 5 commits into
mainfrom
new_summing_merge_tree_test

Conversation

@CarlosFelipeOR
Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • zero_row_deletion_with_update — passes on all versions
  • zero_row_deletion_with_clear_column — xfail on >=25.8 (upstream issue)
  • clear_column_validation_consistency — xfail on all versions (upstream issue)

Comment thread engines/tests/summing_merge_tree/summing_merge_tree.py Outdated
Comment thread engines/tests/summing_merge_tree/summing_merge_tree.py Outdated
Comment thread engines/tests/summing_merge_tree/summing_merge_tree.py Outdated
@Selfeer
Copy link
Copy Markdown
Collaborator

Selfeer commented May 25, 2026

Please review that my changes didn't break your tests - afterwards it's approved from my side

@Selfeer
Copy link
Copy Markdown
Collaborator

Selfeer commented May 25, 2026

The test also lacks requirements

Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
@CarlosFelipeOR CarlosFelipeOR merged commit cf33ff5 into main May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants