Fix registry race test compilation#2040
Open
27rohan wants to merge 1 commit into
Open
Conversation
Update the race-only test to use the current metav1.Object-based Registry API. Signed-off-by: Rohan Thakkar <rohant@twitter.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test_Registry_BasicOperations_ConcurrencyTestchecks if the Registry is safe to use from multiple threads at once. The test had gotten out of date with the code, so it wouldn't even compile — meaning it silently never ran. This PR updates the test to match the current code so the safety check actually works again. No behavior changes to the operator itself.Mechanism
Fixes the race-only Registry test, which didn't compile under -race (so its concurrency coverage never ran), by updating it to the current metav1.Object-based API — no production behavior changes.
metav1.ObjectWalkcallbacks to match the currentmetav1.ObjectAPIThe test currently fails to compile with
-race, so its concurrency coverage never runs.Test plan
go test -mod=readonly -race -count=1 ./pkg/model