Skip to content

[PWGLF] Add centrality and gen daughter momenta components to trackedHypertritonRecoTask table producer - #17865

Merged
maciacco merged 1 commit into
AliceO2Group:masterfrom
creetz16:master
Sep 10, 2026
Merged

maciacco merged 1 commit into
AliceO2Group:masterfrom
creetz16:master

Conversation

@creetz16

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 50 errors, ⚠️ 17 warnings, 🔕 2 disabled

@github-actions github-actions Bot changed the title Add centrality and gen daughter momenta components to trackedHypertritonRecoTask table producer [PWGLF] Add centrality and gen daughter momenta components to trackedHypertritonRecoTask table producer Sep 10, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 13336cd at 2026-09-10 16:23:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 47 warnings.'
Found 1 errors and 47 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/56b06c99a05dc12dc2a6d62163abd850ea7ae66f/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Nuspex/trackedHypertritonRecoTask.cxx:782:57: error: the parameter 'tracked3Body' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
++ [[ 47 -gt 0 ]]
++ cat /sw/BUILD/56b06c99a05dc12dc2a6d62163abd850ea7ae66f/O2Physics-code-check/warnings.txt
PWGLF/DataModel/Vtx3BodyTables.h:117:42: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/DataModel/Vtx3BodyTables.h:118:38: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/DataModel/Vtx3BodyTables.h:119:46: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/DataModel/Vtx3BodyTables.h:120:42: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:78:34: warning: variable 'metadataInfo' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:90:14: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:103:8: warning: constructor does not initialize these fields: mRunNumber, d_bz, ccdb [cppcoreguidelines-pro-type-member-init]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:124:50: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:222:10: warning: constructor does not initialize these fields: label, genCt, genPhi, genEta, genRapidity, isReco, motherLabel, motherPdgCode, daughterPrPdgCode, daughterPiPdgCode, daughterDePdgCode, isDeuteronPrimary, survivedEventSel [cppcoreguidelines-pro-type-member-init]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:294:30: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:294:61: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:382:11: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:436:9: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:436:43: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:441:30: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:441:61: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:448:32: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:455:30: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:455:66: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:455:97: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:485:48: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:516:43: warning: use nullptr [modernize-use-nullptr]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:553:11: warning: variable 'magField' is not initialized [cppcoreguidelines-init-variables]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:555:19: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:732:13: warning: variable 'tofNSigmaDeuteron' is not initialized [cppcoreguidelines-init-variables]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:806:13: warning: do not use 'else' after 'continue' [readability-else-after-return]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:883:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:885:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:887:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:889:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:891:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:893:87: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:1080:9: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:1086:9: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:1112:9: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:1119:9: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:1185:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:1262:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:1283:5: warning: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow]
[0 more errors; see full log]

Full log here.

@maciacco

Copy link
Copy Markdown
Collaborator

@creetz16 approving now as this should run asap in Hyperloop. Please fix linter errors in the next one (missing initializers, variable shadowing, unnecessary else if)

@maciacco
maciacco merged commit 38cf847 into AliceO2Group:master Sep 10, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants