Skip to content

[PWGEM/Dilepton] update qa histograms for muon dca - #17744

Merged
dsekihat merged 2 commits into
AliceO2Group:masterfrom
dsekihat:qc
Sep 4, 2026
Merged

[PWGEM/Dilepton] update qa histograms for muon dca#17744
dsekihat merged 2 commits into
AliceO2Group:masterfrom
dsekihat:qc

Conversation

@dsekihat

@dsekihat dsekihat commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

[PWGEM/Dilepton] update qa histograms for muon dca

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 181 errors, ⚠️ 264 warnings, 🔕 0 disabled

@dsekihat
dsekihat enabled auto-merge (squash) September 3, 2026 09:08
alibuild
alibuild previously approved these changes Sep 3, 2026

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 524dd98 at 2026-09-03 15:44:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 20 warnings.'
Found 6 errors and 20 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/6f6310bfb7033985602580e536fb346a9d5de22f/O2Physics-code-check/errors.txt
PWGEM/Dilepton/Core/SingleTrackQCMC.h:90:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:888:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:1095:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/Core/SingleTrackQC.h:87:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/Core/SingleTrackQC.h:774:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/Core/SingleTrackQC.h:833:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
++ [[ 20 -gt 0 ]]
++ cat /sw/BUILD/6f6310bfb7033985602580e536fb346a9d5de22f/O2Physics-code-check/warnings.txt
PWGEM/Dilepton/Core/SingleTrackQCMC.h:67:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:266:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:267:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:269:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:479:39: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:480:43: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:481:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:627:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:628:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:847:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:971:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:1065:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQC.h:68:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/Core/SingleTrackQC.h:263:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQC.h:265:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
PWGEM/Dilepton/Core/SingleTrackQC.h:418:39: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/SingleTrackQC.h:419:43: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/SingleTrackQC.h:420:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGEM/Dilepton/Core/SingleTrackQC.h:725:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQC.h:811:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 2f2f407 at 2026-09-03 18:41:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 20 warnings.'
Found 6 errors and 20 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/642dbdbf7f796f3b6c9a27e5f83426314827e7b9/O2Physics-code-check/errors.txt
PWGEM/Dilepton/Core/SingleTrackQCMC.h:90:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:888:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:1095:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/Core/SingleTrackQC.h:87:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/Core/SingleTrackQC.h:774:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/Core/SingleTrackQC.h:833:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
++ [[ 20 -gt 0 ]]
++ cat /sw/BUILD/642dbdbf7f796f3b6c9a27e5f83426314827e7b9/O2Physics-code-check/warnings.txt
PWGEM/Dilepton/Core/SingleTrackQCMC.h:67:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:266:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:267:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:269:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:479:39: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:480:43: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:481:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:627:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:628:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:847:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:971:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQCMC.h:1065:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQC.h:68:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/Core/SingleTrackQC.h:263:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQC.h:265:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
PWGEM/Dilepton/Core/SingleTrackQC.h:418:39: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/SingleTrackQC.h:419:43: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/SingleTrackQC.h:420:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGEM/Dilepton/Core/SingleTrackQC.h:725:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/SingleTrackQC.h:811:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

@dsekihat
dsekihat merged commit dcc5041 into AliceO2Group:master Sep 4, 2026
10 of 13 checks passed
@dsekihat
dsekihat deleted the qc branch September 4, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants