[PWGCF] Update CCDB reading - #17641
Merged
Merged
Conversation
fsii
requested review from
SwatiSaha-1997,
alibuild,
dsarkaralice,
isputows,
lauraser and
victor-gonzalez
as code owners
August 27, 2026 14:27
|
O2 linter results: ❌ 0 errors, |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CCDB object handling in PWGCF/EbyEFluctuations/Tasks/partNumFluc.cxx by switching from “load everything for all run groups up front” to a cached “load-on-run-group-change” approach, and refactors the fluctuation-calculator product construction to avoid repeated nested loops.
Changes:
- Refactors compile-time key generation (
ExponentKeys,OrderKeys) and introducesOrderKeyProductLinksto speed upFluctuationCalculatorTrack::getProducts(). - Updates
FluctuationCalculatorTrackinternals (noexcept,addQ, and product-building logic). - Reworks CCDB reading into
readCcdb<true>()(init-time run map) andreadCcdb<false>()(per-run-group cached payload loading), replacing per-run-group vectors with per-current-run-group cached arrays.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
isputows
enabled auto-merge (squash)
August 27, 2026 16:20
isputows
disabled auto-merge
August 27, 2026 16:23
SwatiSaha-1997
enabled auto-merge (squash)
August 27, 2026 16:29
SwatiSaha-1997
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.