[PWGLF] Add QA histograms - #17440
Merged
Merged
Conversation
|
O2 linter results: ❌ 12 errors, |
romainschotter
marked this pull request as ready for review
August 12, 2026 20:51
romainschotter
requested review from
alibuild,
ercolessi,
lhusova,
mpuccio,
omvazque and
skundu692
as code owners
August 12, 2026 20:51
romainschotter
enabled auto-merge (squash)
August 12, 2026 20:51
alibuild
previously approved these changes
Aug 12, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @romainschotter.
Collaborator
|
Error while checking build/O2Physics/code-check for 21279dd at 2026-08-12 23:05: Full log here. |
romainschotter
disabled auto-merge
August 12, 2026 22:00
romainschotter
enabled auto-merge (squash)
August 12, 2026 22:00
alibuild
previously approved these changes
Aug 12, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @romainschotter.
romainschotter
disabled auto-merge
August 12, 2026 22:01
romainschotter
enabled auto-merge (squash)
August 12, 2026 22:01
alibuild
approved these changes
Aug 12, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @romainschotter.
Collaborator
|
Error while checking build/O2Physics/code-check for 35936a2 at 2026-08-17 12:12: Full log here. |
vkucera
disabled auto-merge
August 13, 2026 14:45
vkucera
requested changes
Aug 13, 2026
vkucera
left a comment
vkucera
left a comment
Collaborator
There was a problem hiding this comment.
The PR title is too vague. Please specify the scope of the changes (i.e. file or analysis). See the contribution guidelines.
romainschotter
enabled auto-merge (squash)
August 13, 2026 22:07
alibuild
approved these changes
Aug 13, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @romainschotter.
vkucera
disabled auto-merge
August 13, 2026 22:25
Collaborator
|
Dear @vkucera, this PR is currently blocked because of your request for changes. However, the requested changes are based on an optional CI check. Could you please remove the blocking review and leave the corresponding comments as non-blocking feedback instead? |
Collaborator
Dear @mpuccio , if by "optional" you mean "can be ignored", then we don't have optional CI checks. The CI errors are input for the human reviewer to request fixing issues that a PR would introduce. Merging PRs with red CI sabotages this process, as was done in the initial PR that added this file. Please make sure that all LF code owners understand this. |
Collaborator
|
Dear @vkucera, no, by optional I do not mean that its findings should be ignored. They are certainly useful input for reviewers and code owners, and authors should be encouraged to address them. The point is whether findings from a non-mandatory CI check can, by themselves, be used to block a PR. My understanding is that this decision belongs to the relevant code owners, unless there is an agreed repository-wide policy making these checks mandatory. If this understanding is incorrect, I think we should clarify it with Analysis Coordination and apply the resulting policy consistently to all PRs. For this PR, I would therefore ask that the final decision on whether these findings are merge-blocking be left to the LF code owners (that would be us). |
Collaborator
Absolutely yes. That is the whole point of CI.
The policy is that code owners can decide to ignore some CI errors if there is a good justification for it. By default, errors should be fixed when they are spotted, if feasible.
In this case, the code breaks header dependencies and introduces uninitialised variables. These are absolutely merge-blocking. LF code owners should not have the impression they can ignore these kind of errors. This is why I blocked the merging. |
Collaborator
|
Dear @romainschotter , @mpuccio and @vkucera , |
Collaborator
Author
|
Dear @dsekihat ! |
Collaborator
|
Error while checking build/O2Physics/o2 for 35936a2 at 2026-08-17 15:14: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.