Skip to content

[PWGCF] EbyE finalized errors on moments using subsampling#17018

Open
baasingh wants to merge 2 commits into
AliceO2Group:masterfrom
baasingh:featfmsubsampling
Open

[PWGCF] EbyE finalized errors on moments using subsampling#17018
baasingh wants to merge 2 commits into
AliceO2Group:masterfrom
baasingh:featfmsubsampling

Conversation

@baasingh

@baasingh baasingh commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Jul 11, 2026
@github-actions github-actions Bot changed the title PWGCF: EbyE finalized errors on moments using subsampling [PWGCF] EbyE finalized errors on moments using subsampling Jul 11, 2026
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@alibuild

alibuild commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4299406 at 2026-07-11 08:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 13 errors and 6 warnings.'
Found 13 errors and 6 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/00a6e6e3048522fa3654cda503a0d16a36a2a6e7/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:56:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:56:7: error: variable 'tmpFqErr' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:57:7: error: variable 'collisionZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:58:8: error: constructor does not initialize these fields: pdg, binningM, fqEvent, fqEventSampled, binConEvent, binConEventSampled [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:170:16: error: member 'dcaxyMaxTrackPar0' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:171:16: error: member 'dcaxyMaxTrackPar1' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:172:16: error: member 'dcaxyMaxTrackPar2' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:173:16: error: member 'dcazMaxTrack' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:206:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:289:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:299:42: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:299:73: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:544:10: error: implicit conversion 'unsigned long long' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/00a6e6e3048522fa3654cda503a0d16a36a2a6e7/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:390:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:392:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:394:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:470:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:472:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:474:47: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 13 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for a5e9275 at 2026-07-12 14:52:

## sw/BUILD/O2Physics-latest/log
2026-07-12T06:25:52.318+0200 [51917:140273345719936] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T06:25:52.318+0200 [51917:140273345719936] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-12T06:27:12.322+0200 [51917:140273345719936] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T06:25:51.781+0200 [51873:140027164532352] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T06:25:51.789+0200 [51873:140027164532352] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-12T06:28:13.646+0200 [51873:140027164532352] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T06:27:35.962+0200 [51964:140057126649472] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T06:27:35.962+0200 [51964:140057126649472] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-12T06:29:15.969+0200 [51964:140057126649472] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T06:25:52.646+0200 [51896:139998604230272] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T06:25:52.646+0200 [51896:139998604230272] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-12T06:30:25.724+0200 [51896:139998604230272] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T09:53:48.011+0200 [51324:140572750806656] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: Socket closed]
2026-07-12T09:54:08.014+0200 [51324:140572750806656] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T10:01:32.130+0200 [49532:140624176766592] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: Socket closed]
2026-07-12T10:01:52.134+0200 [49532:140624176766592] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T10:20:42.444+0200 [51323:140085493640832] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: Socket closed]
2026-07-12T10:21:02.447+0200 [51323:140085493640832] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T10:22:04.238+0200 [49822:139935320682112] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: Socket closed]
2026-07-12T10:22:24.242+0200 [49822:139935320682112] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T10:22:34.565+0200 [50080:139677543997056] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: Socket closed]
2026-07-12T10:22:54.569+0200 [50080:139677543997056] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-12T14:52:15.414+0200 [49772:139903494491776] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: Socket closed]
2026-07-12T14:52:15.414+0200 [49498:139967426326144] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-12T14:52:15.416+0200 [49498:139967426326144] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-12T14:52:15.414+0200 [49904:139630238469760] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-12T14:52:15.416+0200 [49904:139630238469760] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-12T14:52:15.414+0200 [49948:140063233678976] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-12T14:52:15.416+0200 [49948:140063233678976] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-12T14:52:15.414+0200 [51010:139818388168320] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-12T14:52:15.416+0200 [51010:139818388168320] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-12T14:52:15.414+0200 [51036:140292896337536] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-12T14:52:15.417+0200 [51036:140292896337536] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-12T14:52:15.414+0200 [51281:140232323763840] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-12T14:52:15.416+0200 [51281:140232323763840] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-12T14:52:15.415+0200 [49597:140378601533056] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-12T14:52:15.419+0200 [49597:140378601533056] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-12T14:52:15.414+0200 [51609:140403729698432] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-12T14:52:15.419+0200 [51609:140403729698432] [executioncontext.cpp:739] [ERROR] Failed to download output blob 7e09facc3cefbac7100ac15c9aeba556bdbc77402dc56f1ed43ae13358875857: 14: Socket closed
2026-07-12T14:52:15.415+0200 [51707:140078916615808] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-12T14:52:15.419+0200 [51707:140078916615808] [executioncontext.cpp:739] [ERROR] Failed to download output blob 5bd354dea79808be0986f714790d21b7d0d6c2144458f106f53b47b81572900a: 14: Socket closed
2026-07-12T14:52:15.415+0200 [51736:140673805004416] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-12T14:52:15.420+0200 [51736:140673805004416] [executioncontext.cpp:739] [ERROR] Failed to download output blob e4fd88d78c26916e1b992f4ce0f9dfe706afd2c4aa87634a4bab71c7cc1e76b1: 14: Socket closed
2026-07-12T14:52:15.415+0200 [51763:139644778913408] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-12T14:52:15.419+0200 [51763:139644778913408] [executioncontext.cpp:739] [ERROR] Failed to download output blob 7b772f0d791bd25b86cd439a48d7374db948986ea292e5db8d0e050a3035105c: 14: Socket closed
2026-07-12T14:52:15.414+0200 [51801:139828904013440] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-12T14:52:15.416+0200 [51801:139828904013440] [executioncontext.cpp:739] [ERROR] Failed to download output blob 5278f9c73b205e54c4454009c90214fb66db6675256b7db580c46ebaacecebe9: 14: Socket closed
2026-07-12T14:52:15.414+0200 [51823:140295853915776] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a5e9275 at 2026-07-12 19:24:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 13 errors and 6 warnings.'
Found 13 errors and 6 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/5f09c0001309ff55def155366dcf3056d7887b26/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:50:1: error: included header string_view is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:56:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:56:7: error: variable 'tmpFqErr' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:57:7: error: variable 'collisionZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:58:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:170:16: error: member 'dcaxyMaxTrackPar0' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:171:16: error: member 'dcaxyMaxTrackPar1' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:172:16: error: member 'dcaxyMaxTrackPar2' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:203:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:286:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:296:42: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:296:73: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:541:10: error: implicit conversion 'unsigned long long' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/5f09c0001309ff55def155366dcf3056d7887b26/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:387:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:389:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:391:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:467:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:469:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:471:47: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 13 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@SwatiSaha-1997 SwatiSaha-1997 Awaiting requested review from SwatiSaha-1997 SwatiSaha-1997 is a code owner
@isputows isputows Awaiting requested review from isputows isputows is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baasingh @alibuild