[PWGEM] PhotonMeson: Fix bug in photonconversionbuilder `v0photoncand…#16966
Merged
mhemmer-cern merged 3 commits intoJul 8, 2026
Merged
Conversation
…idate.setPhotonCandidate` - Fix a bug of swapped arugments in the function call `v0photoncandidate.setPhotonCandidate` where `eledcaXY` and `posdcaZ` were swapped. - Fix clang-tidy warnings and errors in photonconversionbuilder
mhemmer-cern
requested review from
alibuild,
dsekihat,
hscheid and
jokonig
as code owners
|
O2 linter results: ❌ 38 errors, |
alibuild
previously approved these changes
Jul 8, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
Collaborator
|
Error while checking build/O2Physics/code-check for 62adc94 at 2026-07-08 17:07: Full log here. |
alibuild
approved these changes
Jul 8, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
mcoquet642
pushed a commit
to AliceMCH/O2Physics
that referenced
this pull request
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…idate.setPhotonCandidate`
v0photoncandidate.setPhotonCandidatewhereeledcaXYandposdcaZwere swapped.