[PWGCF] FemtoUniverse: Add 3D histogram of TOF Nsigma, pT and centrality for purity studies#16960
Merged
Merged
Conversation
alicja-pp
requested review from
alibuild,
lauraser,
lgraczykCern,
prchakra,
shouqiye,
victor-gonzalez and
wrzesaCERN
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 4 errors, |
Collaborator
|
Error while checking build/O2Physics/code-check for 0eb4189 at 2026-07-08 13:11: Full log here. |
prchakra
approved these changes
Jul 8, 2026
vkucera
reviewed
Jul 8, 2026
Comment on lines
+363
to
+375
| switch (PDGcode) { | ||
| case 2212: // Proton+ | ||
| case -2212: // Proton- | ||
| return trackCuts.getNsigmaTOF(part, o2::track::PID::Proton); | ||
| case 211: // Pion+ | ||
| case -211: // Pion- | ||
| case 111: // Pion 0 | ||
| return trackCuts.getNsigmaTOF(part, o2::track::PID::Pion); | ||
| case 321: // Kaon+ | ||
| case -321: // Kaon- | ||
| case 130: // Kaon 0 LONG | ||
| case 310: // Kaon 0 SHORT | ||
| return trackCuts.getNsigmaTOF(part, o2::track::PID::Kaon); |
Collaborator
There was a problem hiding this comment.
Why are you using magic numbers instead of named constants?
Contributor
Author
There was a problem hiding this comment.
I am correcting it now. The linter did not point out the issues in those changes.
Collaborator
|
@prchakra Why did you approve the PR despite the errors and bugs? |
Collaborator
|
Hi @vkucera, most of the errors reported by |
Collaborator
The bugs I am referring to are the uninitialised variables and members and narrowing conversions detected by the code check. |
Collaborator
Yes, as they were not newly introduced and could require a bit of time to fix them all, I approved them. Anyway, some of them will be fixed now by @alicja-pp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackTrackMultKtExtended.cxx:add 3D histogram of TOF Nsigma, pT and centrality for purity studies
TOF Nsigma axis can be set with confTOFnSigmaBins configurable