Skip to content

[PWGCF] zdcQvectors: Apply selected event selections before filling histograms#16917

Open
cnkoster wants to merge 6 commits into
AliceO2Group:masterfrom
cnkoster:master
Open

[PWGCF] zdcQvectors: Apply selected event selections before filling histograms#16917
cnkoster wants to merge 6 commits into
AliceO2Group:masterfrom
cnkoster:master

Conversation

@cnkoster

@cnkoster cnkoster commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title zdcQvectors: Apply selected event selections before filling histograms [PWGCF] zdcQvectors: Apply selected event selections before filling histograms Jul 3, 2026
@cnkoster cnkoster marked this pull request as ready for review July 6, 2026 07:57
@alibuild

alibuild commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7d315ad at 2026-07-06 10:07:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 52 errors and 23 warnings.'
Found 52 errors and 23 warnings.
++ [[ 52 -gt 0 ]]
++ cat /sw/BUILD/41c0400cf2421624fc2e3118ab479b065db3800e/O2Physics-code-check/errors.txt
PWGCF/Flow/TableProducer/zdcQVectors.cxx:56:10: error: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:58:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:70:5: error: variable 'counter' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:74:22: error: variable 'namesEcal' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:75:35: error: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:76:22: error: variable 'namesTS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:77:22: error: variable 'vnames' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:80:21: error: variable 'pxZDC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:81:21: error: variable 'pyZDC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:82:8: error: variable 'alphaZDC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:85:21: error: variable 'q' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:86:21: error: variable 'qNoEq' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:89:21: error: variable 'eZN' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:90:21: error: variable 'meanEZN' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:91:21: error: variable 'e' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:94:7: error: variable 'centrality' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:95:5: error: variable 'runnumber' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:96:5: error: variable 'lastRunNumber' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:97:20: error: variable 'v' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:98:6: error: variable 'isSelected' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:99:20: error: variable 'cents' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:100:10: error: variable 'timestamp' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:101:8: error: variable 'rsTimestamp' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:102:5: error: variable 'totalTowers' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:103:5: error: variable 'totalTowersPerSide' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:109:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:442:42: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:442:58: error: the parameter 'zdcBC' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:493:37: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:493:63: error: the parameter 'bunchCrossing' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:496:10: error: variable 'selected' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:635:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:705:37: error: the parameter 'ccdb_dir' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:714:29: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:733:14: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:735:7: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:735:21: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:736:14: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:738:7: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:738:21: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:742:14: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/Flow/TableProducer/zdcQVectors.cxx:755:7: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants