DPL: add allocator to forward a fair::mq::Message payload by shallow copy#15577
Open
ehellbar wants to merge 2 commits into
Open
DPL: add allocator to forward a fair::mq::Message payload by shallow copy#15577ehellbar wants to merge 2 commits into
ehellbar wants to merge 2 commits into
Conversation
ehellbar
force-pushed
the
pr15577
branch
3 times, most recently
from
3ed2618 to
b3ff9aa
Compare
ktf
reviewed
Jul 7, 2026
| [[nodiscard]] DataRefIndices initialIndices() const { return {0, 1}; } | ||
| [[nodiscard]] DataRefIndices endIndices() const { return {size_t(-1), size_t(-1)}; } | ||
| [[nodiscard]] DataRef getAtIndices(DataRefIndices idx) const { return record->getAtIndices((int)slot, idx); } | ||
| [[nodiscard]] fair::mq::Message* getPayloadAtIndices(DataRefIndices idx) const { return record->getPayloadAtIndices((int)slot, idx); } |
Member
There was a problem hiding this comment.
don't we already have an helper which does that?
Collaborator
Author
There was a problem hiding this comment.
I don't see it, at least not for what I am doing here.
I define the getter e.g. in https://github.com/AliceO2Group/AliceO2/pull/15577/changes#diff-5d24f98b5c6098b6ad0a1ab814450dec590c82b86147d85c5a34afa0521171a6R239, where I use the DataRefIndices directly since we anyway calculate them in the InputRecordIterator.
There is https://github.com/AliceO2Group/AliceO2/blob/dev/Framework/Core/include/Framework/DataModelViews.h#L209, but it uses some indices from which the vector indices need to be computed first, so it is more expensive than what I need to do. Or are you referring to something else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.