Fix: OTelLinksResponse.count over-counts and writes a removed dropped field

[justin212407]

fixes: #4318

Summary

Fix silent over-counting in tracing ingest responses where OTelLinksResponse.count included dropped spans instead of only accepted spans.

Changes

• Changed:

  count = len(links) + len(dropped)

  to:

  count = len(links)

• Removed stale dropped=... kwarg (field was removed from model but was still being set)

Behavior

Before

• Submitting N spans with K failures returned:
  • count = N
  • only N-K entries in links
• This silently hid partial failures

After

• count now accurately reflects only accepted spans

Testing

Verified locally.

Acceptance Validation

• Fix validated with acceptance tests

QA Follow-up

• Verify /tracing/spans/ingest with mixed valid/invalid span batches returns correct count
• Confirm similar behavior on deprecated /tracing/traces/ingest path using the same patterns

Demo

Files Changed

• router.py
  • Fix count calculation in ingest_spans (line ~303)

Checklist

• Tests pass locally
• Formatting and linting pass (ruff format + ruff check)
• No breaking changes to public API contracts

[vercel]

@justin212407 is attempting to deploy a commit to the agenta projects Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 45978e6f-cd30-48b8-8b59-50ed44745e2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The PR modifies the OpenTelemetry span ingestion response to report only accepted links in the response count and removes the dropped field from the response object, changing the API semantics for reporting span ingestion outcomes.

Changes

Span Ingestion Response Semantics

Layer / File(s)	Summary
OTelLinksResponse count and dropped field update api/oss/src/apis/fastapi/tracing/router.py	The ingest_spans method now constructs OTelLinksResponse with count computed from accepted links only (len(links)) and no longer includes a dropped field value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

• Tracing ingest: OTelLinksResponse.count over-counts and writes a removed dropped field #4318: This PR implements the fix that changes OTelLinksResponse to use count=len(links) and removes the dropped field, directly addressing that issue's objectives.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and accurately describes the main fix: correcting the over-counting in OTelLinksResponse.count and removing the dropped field.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 60.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description clearly explains the bug being fixed, the specific code changes made, the behavioral differences before and after, and includes testing/validation details.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes incorrect OTelLinksResponse.count semantics in the tracing ingest endpoint so the response count reflects only spans successfully accepted/published (i.e., the number of returned links), and removes a stale dropped=... kwarg that no longer exists on the response model.

Changes:

• Update /tracing/spans/ingest response count to len(links) (accepted spans only), instead of len(links) + len(dropped).
• Remove the stale dropped=... argument when constructing OTelLinksResponse.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

api/oss/src/apis/fastapi/tracing/router.py:307

• OTelLinksResponse (see api/oss/src/apis/fastapi/tracing/models.py:108-134) no longer declares a dropped field, so passing dropped=... here is ignored by Pydantic and makes the response construction misleading (and could become a runtime error if extra is tightened). Remove the dropped kwarg from this OTelLinksResponse(...) call (and consider whether dropped should be logged or otherwise surfaced).

            count=len(links),
            links=links,
            dropped=dropped or None,
        )