Fix park-and-ride skim validation with Sharrow - #1113
Merged
jpn-- merged 1 commit intoSep 9, 2026
Conversation
Member
Author
|
@bricegnichols Can you confirm if this PR address the problem? |
Contributor
|
Yes, @jpn-- this solves the issue. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Park-and-ride lot choice crashes with Sharrow when
TRANSIT_SKIMS_FOR_ELIGIBILITYis configured because validation accessesskim_info, whichSkimDatasetdoes not expose.In this PR, we add a common membership interface to
SkimDictandSkimDatasetand use it to validate eligibility skims before lookup. Both backends now accept 2D names and valid(name, time period)keys while retaining the actionable settings error for invalid keys.Add 44 parameterized unit/regression cases using concrete NumPy and Sharrow skim backends. Coverage includes 2D and AM/PM skims, combined accessibility across lots and skims, repeated destinations and output order, missing/negative values, no accessible destinations, and invalid skim names or periods.
Validation:
test_pnr_skim_eligibility.py,test_park_and_ride_models.py,test_skim.py, andtest_los.py.AttributeError: 'SkimDataset' object has no attribute 'skim_info'in all five Sharrow filtering regression cases.The original password-protected inputs were unavailable; validation uses synthetic skims rather than a full run of the reported model.
Fixes #1111.
Note: This PR authored by GPT-6-Astra-Medium.