-
Notifications
You must be signed in to change notification settings - Fork 752
Update uk-ua.json #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update uk-ua.json #1830
Conversation
small translation
Summary of ChangesHello @PavloPogonets, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the Ukrainian localization of the application. It translates a set of previously untranslated user interface elements and messages, ensuring a more comprehensive and native-language experience for Ukrainian-speaking users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Ukrainian translation file. The new translations are a good starting point, but I've found several areas where improvements can be made for better accuracy, consistency, and grammatical correctness in Ukrainian. I've left specific suggestions to address these points.
| "security type": "Security Type", | ||
| "connection mode": "Connection mode", | ||
| "port": "Port", | ||
| "feedback": "Зворотній зв'язок", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "diagonal scrolling": "Діагональне прокручування", | ||
| "reverse scrolling": "Зворотне прокручування", | ||
| "formatter": "Форматувальник", | ||
| "format on save": "Формат при збереженні", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation 'Формат при збереженні' is a bit too literal for 'Format on save'. A more natural-sounding phrase in Ukrainian would be 'Форматування при збереженні', which uses the noun form for 'formatting'.
| "format on save": "Формат при збереженні", | |
| "format on save": "Форматування при збереженні", |
| "scroll settings": "Налаштування прокрутки", | ||
| "scroll speed": "Швидкість прокрутки", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other related terms like 'Діагональне прокручування' (diagonal scrolling), it would be better to use the noun 'прокручування' instead of 'прокрутки'. This will make the terminology more consistent across the UI.
| "scroll settings": "Налаштування прокрутки", | |
| "scroll speed": "Швидкість прокрутки", | |
| "scroll settings": "Налаштування прокручування", | |
| "scroll speed": "Швидкість прокручування", |
| "no plugins found": "Плагіни не знайдені", | ||
| "name": "Ім'я", | ||
| "username": "Ім'я користувача", | ||
| "optional": "опціонально", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "api_error": "API server down, please try after some time.", | ||
| "installed": "Встановлено", | ||
| "all": "All", | ||
| "all": "Все", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "verified publisher": "Verified publisher", | ||
| "most_downloaded": "Most Downloaded", | ||
| "newly_added": "Newly Added", | ||
| "most_downloaded": "Найпопулярніші завантаження", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation 'Найпопулярніші завантаження' means 'most popular downloads'. A more accurate translation for 'Most Downloaded' would be 'Найбільш завантажувані', which directly translates to 'most downloaded'.
| "most_downloaded": "Найпопулярніші завантаження", | |
| "most_downloaded": "Найбільш завантажувані", |
Greptile SummaryThis PR improves the Ukrainian localization by translating 36 previously English strings to Ukrainian, bringing the translation closer to completion.
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant File as uk-ua.json
participant App as Acode App
participant User as Ukrainian User
Dev->>File: Update 36 English strings to Ukrainian
Note over File: Translate UI elements:<br/>feedback, header, sidebar,<br/>browser, plugin
Note over File: Translate scroll settings:<br/>diagonal scrolling,<br/>reverse scrolling
Note over File: Translate connection terms:<br/>username, hostname,<br/>password, port
Note over File: Translate messages:<br/>thank you :),<br/>restore warning
Dev->>File: Validate JSON syntax
File->>App: Load updated translations
App->>User: Display Ukrainian interface
User->>App: View localized UI elements
Note over User: Better user experience<br/>with native language
|
small translation