Adapt to rocq-prover/rocq#21987 (clear checks that ids are bound even when from match goal)#582
Closed
SkySkimmer wants to merge 1 commit intoAbsInt:masterfrom
Closed
Adapt to rocq-prover/rocq#21987 (clear checks that ids are bound even when from match goal)#582SkySkimmer wants to merge 1 commit intoAbsInt:masterfrom
SkySkimmer wants to merge 1 commit intoAbsInt:masterfrom
Conversation
… when from match goal)
Contributor
|
Thanks for the early notice and for the patch. Just curious: the "clear" was to ensure that the same hypothesis is destructed at most once. If "clear" fails, what prevents the "repeat" to loop forever? |
Contributor
Author
|
Nothing I guess, but it doesn't seem to happen in practice (see green CI). AFAICT for it to loop H would need to be a section variable (otherwise destruct would clear it) and would need to appear in the goal (to make clear fail). |
Contributor
|
Gosh, you're right, |
Contributor
|
Works great without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.