USB Device: Fix INTERVAL_HS array out-of-bounds access <151> - #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes bug #151 . The structure that holds the bInterval parameter for high speed is changed to store the actual value, not the value converted to micro frames. This is because the code in usbd_lib_hid.c uses the actual values to index an array of polling times. Note that the polling time is normally in micro frames so it could technically poll each 125 us. Our HID timer is activated each 4 ms, so this is a little hard. The INTERVAL_HS array thus converts the time to ms, for the really low values it will be 1ms. For polling times not dividable with 4 (like 1), the polling code does the same as always - nothing.