fix: call onCircular callback for all occurrences of circular $refs#408
Merged
jonluca merged 2 commits intoAPIDevTools:mainfrom Jan 24, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 21308961385Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
🎉 This PR is included in version 15.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #407
The
onCircularcallback was only invoked for the first detection of each unique circular reference target, not for every occurrence. This was an unintended side effect of the caching optimizations in #380 and #381.Changes
foundCircularReference(path, $refs, options)calls before returning cached circular results inlib/dereference.tscircular-extensivetests to verify correct callback counts (118 paths withcircular: true, 173 withcircular: 'ignore')circular-multi-occurrencetest specifically targeting the multiple occurrence scenarioNotes
onDereferencewhich correctly fires for every$refcircular: true(118) andcircular: 'ignore'(173) is expected due to traversal behavior differences (documented in tests)