Skip to content

log lr hyperparams; add exact match reward#3417

Open
andytwigg wants to merge 9 commits intomainfrom
atwigg/log_lr_hyperparam
Open

log lr hyperparams; add exact match reward#3417
andytwigg wants to merge 9 commits intomainfrom
atwigg/log_lr_hyperparam

Conversation

@andytwigg
Copy link
Collaborator

@andytwigg andytwigg commented Mar 14, 2026

Description

inject LR as hyperparam to let tunix log LR
add exact match reward

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/trainers/post_train/rl/utils_rl.py 0.00% 13 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy. This also includes a bunch of configs so maybe just update the PR title to reflect that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants