Explicitly pass qwix config for deepseek batch split#3405
Draft
shuningjin wants to merge 1 commit intomainfrom
Draft
Explicitly pass qwix config for deepseek batch split#3405shuningjin wants to merge 1 commit intomainfrom
shuningjin wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
16d567f to
cd2d86f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix: b/489513157
Overview
PR 3182 switched deepseek batch split config to use pure JAX, which broke the existing Qwix integration that relies on the Qwix interception feature. As a workaround, PR 3319 explicitly pass the QwixRule to gmm kernels.
This PR furthers the workaround. We explicitly pass the QwixQuantization to individual layers, in a similar vein as existing AQTQuantization.
In summary,
Main Changes
quantization.pyQwixQuantization, similar to AQTQuantizationdot_general_clsandeinsum, withQwixDotGeneralandQwixEinsumqwix._src.core.dot_general_qt.dot_general_qtconfig, with "fp8_full" and calibration methoddeepseek_batchsplit.pydotto use quantized versionquant.dot_general_clsquantto methodsTests
locally on v5p-8 for deepseek3-test (trim down to 2 dense layer + 2 MoE layer)
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.