Conversation
ffd00f3 to
ea56990
Compare
| context: . | ||
| file: ${{ inputs.dockerfile }} | ||
| tags: gcr.io/tpu-prod-env-multipod/${{ inputs.image_name }}:latest | ||
| tags: gcr.io/tpu-prod-env-multipod/${{ inputs.image_name }}:${{ inputs.image_date }}-build-${{ github.run_id }} |
There was a problem hiding this comment.
@SurbhiJainUSC we need to discuss what tags do we want to add to the images before and after testing.
Current:
- before tests: ${{ github.run_id }}, and hashes of the repos
- after tests: "latest", and "<image_date>"
3b2089d to
8ca7650
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
be50e5b to
71076a6
Compare
There was a problem hiding this comment.
Why do we need a different workflow for testing the docker image?
Can we update build_and_push_docker_image.yml to something like this:
# https://github.com/AI-Hypercomputer/maxtext/blob/main/.github/workflows/build_and_push_docker_image.yml#L111
- name: Build and push Docker image
# Runs tests on docker image with tag as ${{ github.run_id }}
- name: Test Dokcer Image
# [Add tags such as ](https://github.com/AI-Hypercomputer/maxtext/blob/main/.github/workflows/build_and_push_docker_image.yml#L129)
- name: Add tags to Docker Image
There was a problem hiding this comment.
Merged the jobs into build_and_push_docker_image.yml and now tests are executed immediately after the image has been pushed.
One caveat: since the tpu-post-training-nightly depends on tpu-post-training-stable, the whole workflow needs more time to finish because it now waits for the test to be done.
| uses: ./.github/workflows/build_and_push_docker_image.yml | ||
| with: | ||
| image_name: maxtext_post_training_stable | ||
| image_name: maxtext_post_training_stable${{ needs.setup.outputs.image_suffix }} |
There was a problem hiding this comment.
Please rebase, this has been moved out of UploadDockerImages.yml
There was a problem hiding this comment.
Can we move testing the docker image job before this step?
There was a problem hiding this comment.
We should tag the image with appropriate tags once our testing passes.
ea0f4ee to
5563359
Compare
- images will only be tagged with date and to "latest" when tests pass
Description
Tests
See this manually triggered workflow run
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.