Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 74 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 0 | 59 | 15 | 0 |
Click to see the invalid file list
- examples/platform/cert_store.rs
- examples/platform/certs.rs
- examples/platform/crypto.rs
- examples/platform/evidence.rs
- examples/platform/mod.rs
- examples/platform/socket_transport.rs
- examples/spdm_requester.rs
- examples/spdm_responder.rs
- src/cert_store.rs
- src/chunk_ctx.rs
- src/codec.rs
- src/commands/algorithms/mod.rs
- src/commands/algorithms/request.rs
- src/commands/algorithms/response.rs
- src/commands/capabilities/mod.rs
- src/commands/capabilities/request.rs
- src/commands/capabilities/response.rs
- src/commands/certificate/mod.rs
- src/commands/certificate/request.rs
- src/commands/certificate/response.rs
- src/commands/challenge/mod.rs
- src/commands/challenge/request.rs
- src/commands/challenge/response.rs
- src/commands/chunk_get_rsp.rs
- src/commands/digests/mod.rs
- src/commands/digests/request.rs
- src/commands/digests/response.rs
- src/commands/error_rsp.rs
- src/commands/measurements/mod.rs
- src/commands/measurements/request.rs
- src/commands/measurements/response.rs
- src/commands/mod.rs
- src/commands/version/mod.rs
- src/commands/version/request.rs
- src/commands/version/response.rs
- src/context.rs
- src/error.rs
- src/lib.rs
- src/measurements/common.rs
- src/measurements/freeform_manifest.rs
- src/measurements/mod.rs
- src/platform/evidence.rs
- src/platform/hash.rs
- src/platform/mod.rs
- src/platform/rng.rs
- src/platform/transport.rs
- src/protocol/algorithms.rs
- src/protocol/capabilities.rs
- src/protocol/certs.rs
- src/protocol/common.rs
- src/protocol/mod.rs
- src/protocol/signature.rs
- src/protocol/version.rs
- src/requester.rs
- src/state.rs
- src/test.rs
- src/transcript.rs
- src/transport.rs
- tests/spdm_validator_host.rs
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
license-eye has checked 74 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 0 | 59 | 15 | 0 |
Click to see the invalid file list
- examples/platform/cert_store.rs
- examples/platform/certs.rs
- examples/platform/crypto.rs
- examples/platform/evidence.rs
- examples/platform/mod.rs
- examples/platform/socket_transport.rs
- examples/spdm_requester.rs
- examples/spdm_responder.rs
- src/cert_store.rs
- src/chunk_ctx.rs
- src/codec.rs
- src/commands/algorithms/mod.rs
- src/commands/algorithms/request.rs
- src/commands/algorithms/response.rs
- src/commands/capabilities/mod.rs
- src/commands/capabilities/request.rs
- src/commands/capabilities/response.rs
- src/commands/certificate/mod.rs
- src/commands/certificate/request.rs
- src/commands/certificate/response.rs
- src/commands/challenge/mod.rs
- src/commands/challenge/request.rs
- src/commands/challenge/response.rs
- src/commands/chunk_get_rsp.rs
- src/commands/digests/mod.rs
- src/commands/digests/request.rs
- src/commands/digests/response.rs
- src/commands/error_rsp.rs
- src/commands/measurements/mod.rs
- src/commands/measurements/request.rs
- src/commands/measurements/response.rs
- src/commands/mod.rs
- src/commands/version/mod.rs
- src/commands/version/request.rs
- src/commands/version/response.rs
- src/context.rs
- src/error.rs
- src/lib.rs
- src/measurements/common.rs
- src/measurements/freeform_manifest.rs
- src/measurements/mod.rs
- src/platform/evidence.rs
- src/platform/hash.rs
- src/platform/mod.rs
- src/platform/rng.rs
- src/platform/transport.rs
- src/protocol/algorithms.rs
- src/protocol/capabilities.rs
- src/protocol/certs.rs
- src/protocol/common.rs
- src/protocol/mod.rs
- src/protocol/signature.rs
- src/protocol/version.rs
- src/requester.rs
- src/state.rs
- src/test.rs
- src/transcript.rs
- src/transport.rs
- tests/spdm_validator_host.rs
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Member
|
I am currently examining this repo's issues and found #14 . It looks as if all that has to be done for this to be considered completed, we must implement
DeviceModeCapabilities, which is just a bitfield. |
embediver
force-pushed
the
mgudel/measurements
branch
from
589fa3b to
0133253
Compare
There was a problem hiding this comment.
license-eye has checked 76 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 56 | 2 | 18 | 0 |
Click to see the invalid file list
- src/commands/measurements/mod.rs
- src/commands/measurements/request.rs
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
- Measurement data is currently only parsed and discarded
embediver
force-pushed
the
mgudel/measurements
branch
from
0133253 to
0e10400
Compare
Author
|
The means to parse measurement blocks are still missing, but I'm not sure that we need that right now. The verification of the measurement log signature is still missing. |
To append a CHALLENGE or MEASUREMENTS response to the transcript, the signature has to be excluded. For this the message buffer gets resized. Afterwards the messge buffer has to be restored to the original size. This patch fixes the a bug where restoring failed, when the buffer was smaller than the signature.
Author
|
Added the signature verification for the measurement log (L1/L2 transcript). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.