Adding Timestamp decode/encode - #351
Open
junderw wants to merge 2 commits into
Open
Conversation
junderw
marked this pull request as draft
August 18, 2024 15:00
junderw
commented
Aug 19, 2024
junderw
force-pushed
the
junderw/add-timestamps
branch
from
August 20, 2024 17:55
1d51bf6 to
bac67df
Compare
junderw
marked this pull request as ready for review
August 26, 2024 15:48
|
@junderw thank you for getting this started 🙏 I'm interested in using this with serde, but I don't understand either library well enough to know what code to add to |
Author
|
@jcuffe I added a hackey TimestampSerde wrapper. It's a simple wrapper only for serde serialize and deserialize. The content is pub, so you can just take the content out after it's deserialized. I added a test for each way, you can look at the test to see how it works. |
junderw
force-pushed
the
junderw/add-timestamps
branch
from
November 27, 2024 14:57
f4bacae to
d66e6ca
Compare
junderw
force-pushed
the
junderw/add-timestamps
branch
from
November 27, 2024 15:46
d66e6ca to
48d2eb1
Compare
|
Excellent! Thank you @junderw 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a baseline just to have something to work off of, very WIP.
Should we perhaps just use DateTime from the chrono crate under a feature flag instead of creating a simple enum.(I've decided against this, it's too much of a hassle.)How should we go about including it in rmp-serde if at all?(Made an initial implementation, but kind of hacky, awaiting feedback)Let me know if this isn't something you're interested it.