Conversation
Add a PrependArgs FileOption that allows specific plugins to opt into prepending arguments instead of appending. This preserves the default AddArgs behavior for all other plugins while allowing MySQL to place --defaults-file first as required by the mysql CLI.
|
Just noting that this PR would also address the thrust of #508 (albeit in a slightly different fashion) |
|
@mrjones2014 could you take a look at this PR? You reviewed the last attempt to fix this rough edge on the mysql plugin and your feedback was incorporated here. Given how common mysql and 1Password usage is, it feels like this getting this on |
mrjones2014
left a comment
mrjones2014
left a comment
There was a problem hiding this comment.
You'll still have to chase down a second approval.
Full disclosure, I've actually stopped using Shell Plugins since I've been unable to really get anything merged myself.
|
Thank you @mrjones2014 -- appreciate the review and context 🙇 (similarly I was pretty stoked on plugins and then hit issues with the mysql one and set them to the side for a year -- I want to believe!) @AndyTitu any chance you could take a look as you were also in the original PR on this topic? |
4 participants
Overview
This is a continuation of #408, updated to add a separate
PrependArgsand only use it in the mysql plugin.Type of change
Related Issue(s)
How To Test
Changelog
Update mysql plugin to always add
--defaults-fileas the first argument.