fix: allow periods in configuration field labels - #154
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadandload_dictcurrently reject field labels containing periods because the entireopfieldis split into components and exactly two are required. Split only at the first period: it separates the section from the field label, while remaining periods belong to the label. This supports the email-address label reported in #44, including fields outside a section.The docstrings describe this interpretation. Four HTTP-backed regressions cover both entry points with and without a section; all four fail before the fix and pass afterward. All 56 tests pass, and git diff --check passes. Section labels containing periods remain outside the existing path syntax; this change does not add an escape syntax.
Fixes #44.