Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive tests for async-safe and thread-safe dependency injection scenarios, updates two Python package dependencies, and extends CI testing coverage to include Python 3.14t (free-threaded build).
- Adds test for async singleton injection with concurrent task execution using anyio
- Adds test for thread-safe injection with concurrent thread execution using ThreadPoolExecutor
- Updates dependency versions (uv 0.9.22 → 0.9.23, virtualenv 20.36.0 → 20.36.1)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_inject.py | Adds two new test cases: one for async singleton behavior with concurrent async tasks, and one for threadsafe injection with concurrent threads |
| uv.lock | Updates uv package from 0.9.22 to 0.9.23 and virtualenv from 20.36.0 to 20.36.1 with corresponding wheel distributions |
| .github/workflows/ci.yml | Adds Python 3.14t (free-threaded build) to the CI test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.