toString(number, 16) crashes e2

[AlexALX]

Describe the bug

By some reason this code not working with newer wiremod:

    local Rand = toString(random(10000000,159999999), 16)
    local Rand2 = toString(random(10000000,159999999), 16)
    
    print(Rand,Rand)

(sv: Expression 2 (generic): Runtime error 'addons/wire/lua/entities/gmod_wire_expression2/base/compiler.lua:975: invalid value (nil) at index 7 in table for 'concat'' at line -1, char -1)

not sure why. Fixed by replacing random to randint

How to reproduce the bug

No response

[CornerPin]

It seems like tobase was written with only integers in mind. If you pass a number with a non-zero fractional part, the variable d computed at line 592 of number.lua will retain it in the first iteration of the loop. It will then be used to index CHARS, which results in nil getting written into out. This happens with all allowed bases except 10.

wire/lua/entities/gmod_wire_expression2/core/number.lua

Lines 581 to 599 in 074ff60

	local CHARS = string.Split("0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ", "")
	local function tobase(number, base, self)
	if base < 2 or base > 36 or base ~= base or number == 0 or number ~= number then return "0" end
	if base == 10 then return tostring(number) end
	if number < 0 then return "-" .. tobase(-number, base, self) end
	local out, loops, d = {}, floor(log(number) / log(base)) + 1, 0
	if loops == inf then return "inf" end
	for i = loops, 1, -1 do
	number, d = math.floor(number / base), number % base + 1
	out[i] = CHARS[d]
	end
	self.prf = self.prf + loops * 4
	return table.concat(out, "", 1, loops)
	end

This function also doesn't round the base to an integer, so passing a number like base=15.123 will cause the same Lua error.