Skip to content

feat(core): expand runtime/tools surfaces#2828

Closed
gismo212 wants to merge 1 commit into
ultraworkers:mainfrom
gismo212:pr/core-runtime-cli
Closed

feat(core): expand runtime/tools surfaces#2828
gismo212 wants to merge 1 commit into
ultraworkers:mainfrom
gismo212:pr/core-runtime-cli

Conversation

@gismo212

@gismo212 gismo212 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Expand core runtime/tool/CLI/provider surfaces.
  • Update CI and add new helper tools (git_tools, disk).

Test plan

  • From rust/: cargo fmt
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace

@gismo212

Copy link
Copy Markdown
Contributor Author

CI is currently blocked with �ction_required (fork PR workflow approval).

Maintainers: could you please Approve and run the Rust CI workflow for this PR?

Thanks!

Update core CLI/runtime/tooling and provider plumbing, with CI adjustments and new helper tools.

Made-with: Cursor
@gismo212 gismo212 force-pushed the pr/core-runtime-cli branch from bfd32da to 9424ba6 Compare April 28, 2026 13:19
@gismo212

Copy link
Copy Markdown
Contributor Author

Update: rebased pr/core-runtime-cli onto latest main and resolved merge conflicts.

PR should now be mergeable; remaining status is gated on CI approval (action_required) and checks.

@code-yeongyu code-yeongyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has merge conflicts. Please rebase onto main and resolve conflicts.

@code-yeongyu

Copy link
Copy Markdown
Collaborator

Please rebase onto main and force-push — this PR has merge conflicts with the current main. Thanks!

@1716775457damn

Copy link
Copy Markdown

The runtime/tools surface expansion looks solid. Adding git_tools and disk as new helpers is a good coverage addition. CI gates (fmt + clippy -D warnings + test) are correctly enforced. One question: are git_tools and disk fully implemented in this PR or just stubbed out? If stubbed, worth noting in the description so reviewers know what's coming next.

@Yeachan-Heo

Copy link
Copy Markdown
Contributor

Closing this PR as stale — it's been open for 5+ weeks with changes requested and no follow-up. The mergeable state is unknown and the branch appears to have significant conflicts with current main. Feel free to reopen with a fresh rebase if the changes are still relevant.

@Yeachan-Heo Yeachan-Heo closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants