Code cleanup: Address TODO comments in graph-feature-service

[adityaidev]

Description

Several TODO comments in the graph-feature-service module indicate incomplete or planned functionality that should be addressed:

TODOs Found:

1. ServerController.scala

   • // TODO: Disable updateCache after HTL switch to use PresetIntersection endpoint
   • // TODO: Refactor after HTL switch to PresetIntersection

2. ServerGetIntersectionHandler.scala

   • // TODO: Track all the stats based on PresetFeatureType and update the dashboard

3. ServerWarmupHandler.scala

   • // TODO: Add the testing accounts to warm-up the service

4. IntersectionValueCalculator.scala

   • // TODO: for now it only computes intersection size. Will add more feature types

Impact

These TODOs indicate:

• Technical debt that needs to be addressed
• Missing functionality (stats tracking, additional feature types)
• Potential cleanup after migrations

Suggested Actions

1. Review if HTL switch to PresetIntersection is complete
2. Implement stats tracking for PresetFeatureType
3. Add testing accounts for service warmup
4. Extend IntersectionValueCalculator with additional feature types

Files Affected

• graph-feature-service/src/main/scala/com/twitter/graph_feature_service/server/controllers/ServerController.scala
• graph-feature-service/src/main/scala/com/twitter/graph_feature_service/server/handlers/ServerGetIntersectionHandler.scala
• graph-feature-service/src/main/scala/com/twitter/graph_feature_service/server/handlers/ServerWarmupHandler.scala
• graph-feature-service/src/main/scala/com/twitter/graph_feature_service/util/IntersectionValueCalculator.scala