Skip to content

Commit d9458db

Browse files
committed
test(run-engine): fire-and-forget the emitter close on readiness timeout
A quit written to a socket that accepted but never completes the handshake never settles, which made the diagnostic throw unreachable. Closing without awaiting keeps the fast, descriptive failure.
1 parent 5d5ac60 commit d9458db

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

internal-packages/run-engine/src/run-queue/metrics.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ async function emitterReady(emitter: MetricsStreamEmitter) {
3434
const winner = await Promise.race([emitter.waitUntilReady().then(() => "ready"), timedOut]);
3535
abort.abort();
3636
if (winner === "timeout") {
37-
await emitter.close().catch(() => {});
37+
void emitter.close().catch(() => {});
3838
throw new Error("metrics emitter Redis connection never became ready");
3939
}
4040
}

0 commit comments

Comments
 (0)