Skip to content

Commit 97cebf5

Browse files
samejrclaude
andcommitted
chore(webapp): remove explanatory comments from the integration settings changes
Strips the code comments this branch added across the Vercel/Slack integration settings pages and the shared ProjectConnectSelect. Keeps the functional oxlint-disable directive; leaves pre-existing loader/action comments untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent a48fd40 commit 97cebf5

3 files changed

Lines changed: 1 addition & 19 deletions

File tree

apps/webapp/app/components/integrations/ProjectConnectSelect.tsx

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,8 @@ import {
1212

1313
type ConnectableProject = { id: string; slug: string; name: string };
1414

15-
// Matches the label sizing of the main side menu's project switcher.
1615
const MENU_LABEL = "text-[0.90625rem] font-medium tracking-[-0.01em]";
1716

18-
/**
19-
* Blank-state CTA shared by the org integration pages (Vercel, Slack). Picking a
20-
* project navigates straight to where that integration is configured for it, so
21-
* the menu item *is* the action — there's no separate button. Each integration is
22-
* configured on a different page, so the caller supplies `configurePathFor`.
23-
* Styled to match the main side menu's project switcher.
24-
*/
2517
export function ProjectConnectSelect({
2618
projects,
2719
configurePathFor,
@@ -32,7 +24,6 @@ export function ProjectConnectSelect({
3224
const [isOpen, setIsOpen] = useState(false);
3325
const navigation = useNavigation();
3426

35-
// Close once a menu item's navigation kicks off, mirroring the side menu switcher.
3627
useEffect(() => {
3728
// oxlint-disable-next-line react/set-state-in-effect -- sync menu state after navigation.
3829
setIsOpen(false);
@@ -61,7 +52,6 @@ export function ProjectConnectSelect({
6152
title={
6253
<span className="flex w-full items-center justify-between gap-2 text-text-bright">
6354
<span className="min-w-0 grow truncate text-left">{project.name}</span>
64-
{/* In the DOM (reserves space) but only visible on row hover. */}
6555
<ChevronExtraSmallDown className="size-3.5 shrink-0 -rotate-90 text-text-dimmed opacity-0 transition-opacity group-hover/button:opacity-100" />
6656
</span>
6757
}

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.integrations.slack.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,6 @@ export default function SlackIntegrationPage() {
196196
const isUninstalling =
197197
navigation.state === "submitting" && navigation.formData?.get("intent") === "uninstall";
198198

199-
// The org context (parent loader) carries the project list for the connect CTA.
200199
const organization = useOrganization();
201200
const projects = organization.projects;
202201

@@ -218,7 +217,6 @@ export default function SlackIntegrationPage() {
218217
<ProjectConnectSelect
219218
projects={projects}
220219
configurePathFor={(project) =>
221-
// Slack alerts are configured from the Errors page; ?alerts=true opens the sheet.
222220
`${v3ErrorsPath(organization, project, { slug: "prod" })}?alerts=true`
223221
}
224222
/>
@@ -300,8 +298,6 @@ export default function SlackIntegrationPage() {
300298

301299
<SettingsSection>
302300
<SettingsHeader
303-
// Keep the header's divide when there's no table; the table's own top
304-
// border is the divide once rows are present.
305301
className={alertChannels.length === 0 ? undefined : "border-b-0"}
306302
title={`${alertChannels.length} connected alert ${
307303
alertChannels.length === 1 ? "channel" : "channels"

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.integrations.vercel.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,6 @@ export default function VercelIntegrationPage() {
260260
const isUninstalling =
261261
navigation.state === "submitting" && navigation.formData?.get("intent") === "uninstall";
262262

263-
// The org context (parent loader) carries the project list for the connect CTA.
264263
const { projects } = useOrganization();
265264

266265
if (!vercelIntegration) {
@@ -281,7 +280,6 @@ export default function VercelIntegrationPage() {
281280
<ProjectConnectSelect
282281
projects={projects}
283282
configurePathFor={(project) =>
284-
// Default to the production environment, matching the connected-state links.
285283
v3ProjectSettingsIntegrationsPath(organization, project, { slug: "prod" })
286284
}
287285
/>
@@ -387,8 +385,6 @@ export default function VercelIntegrationPage() {
387385

388386
<SettingsSection>
389387
<SettingsHeader
390-
// Keep the header's divide when there's no table; the table's own top
391-
// border is the divide once rows are present.
392388
className={connectedProjects.length === 0 ? undefined : "border-b-0"}
393389
title={`${connectedProjects.length} connected ${
394390
connectedProjects.length === 1 ? "project" : "projects"
@@ -433,7 +429,7 @@ export default function VercelIntegrationPage() {
433429
to={v3ProjectSettingsIntegrationsPath(
434430
organization,
435431
projectIntegration.project,
436-
{ slug: "prod" } // Default to production environment
432+
{ slug: "prod" }
437433
)}
438434
/>
439435
</span>

0 commit comments

Comments
 (0)