From d40522b4db93eda2d131bd8b8d7f4a9929d0fc09 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nguy=E1=BB=85n=20Ti=E1=BA=BFn=20=C4=90=E1=BA=A1t?= <112878795+NguyenTienDat377@users.noreply.github.com> Date: Mon, 10 Aug 2026 16:09:40 +0700 Subject: [PATCH 1/2] Fail fast with a clear exception instead of returning null in getSeleniumAddress() --- .../testcontainers/containers/BrowserWebDriverContainer.java | 3 +-- .../org/testcontainers/selenium/BrowserWebDriverContainer.java | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java b/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java index 53ee8ba5577..ae8b0ec4373 100644 --- a/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java +++ b/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java @@ -280,8 +280,7 @@ public URL getSeleniumAddress() { try { return new URL("http", getHost(), getMappedPort(SELENIUM_PORT), "/wd/hub"); } catch (MalformedURLException e) { - e.printStackTrace(); // TODO - return null; + throw new IllegalStateException("Failed to construct Selenium address", e); } } diff --git a/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java b/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java index 97ac23f5d55..7c63b9f6791 100644 --- a/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java +++ b/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java @@ -179,8 +179,7 @@ public URL getSeleniumAddress() { try { return new URL("http", getHost(), getMappedPort(SELENIUM_PORT), "/wd/hub"); } catch (MalformedURLException e) { - e.printStackTrace(); // TODO - return null; + throw new IllegalStateException("Failed to construct Selenium address", e); } } From 609a11d196813f9e23a4d22c496898acb1ae118f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nguy=E1=BB=85n=20Ti=E1=BA=BFn=20=C4=90=E1=BA=A1t?= <112878795+NguyenTienDat377@users.noreply.github.com> Date: Thu, 13 Aug 2026 00:44:50 +0700 Subject: [PATCH 2/2] Converge on ContainerLaunchException per review feedback, note unreachability --- .../testcontainers/containers/BrowserWebDriverContainer.java | 2 +- .../org/testcontainers/selenium/BrowserWebDriverContainer.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java b/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java index ae8b0ec4373..8227f71c01a 100644 --- a/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java +++ b/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java @@ -280,7 +280,7 @@ public URL getSeleniumAddress() { try { return new URL("http", getHost(), getMappedPort(SELENIUM_PORT), "/wd/hub"); } catch (MalformedURLException e) { - throw new IllegalStateException("Failed to construct Selenium address", e); + throw new ContainerLaunchException("Could not construct Selenium address", e); } } diff --git a/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java b/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java index 7c63b9f6791..af028d9d2f7 100644 --- a/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java +++ b/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java @@ -179,7 +179,7 @@ public URL getSeleniumAddress() { try { return new URL("http", getHost(), getMappedPort(SELENIUM_PORT), "/wd/hub"); } catch (MalformedURLException e) { - throw new IllegalStateException("Failed to construct Selenium address", e); + throw new ContainerLaunchException("Could not construct Selenium address", e); } }