Skip to content

Expose JSON type converter unhandled sentinel type#1556

Open
Lingavasan wants to merge 1 commit into
temporalio:mainfrom
Lingavasan:codex-json-type-converter-unhandled
Open

Expose JSON type converter unhandled sentinel type#1556
Lingavasan wants to merge 1 commit into
temporalio:mainfrom
Lingavasan:codex-json-type-converter-unhandled

Conversation

@Lingavasan
Copy link
Copy Markdown

Summary

  • expose a public JSONTypeConverterUnhandled type for JSONTypeConverter.Unhandled
  • keep the old private _JSONTypeConverterUnhandled name as an internal compatibility alias
  • update the README and converter tests to use the public return type

Fixes #1434

Validation

  • .venv/bin/ruff format --check temporalio/converter/_payload_converter.py temporalio/converter/init.py tests/test_converter.py
  • .venv/bin/ruff check temporalio/converter/_payload_converter.py temporalio/converter/init.py tests/test_converter.py
  • git diff --check
  • .venv/bin/python -m py_compile temporalio/converter/_payload_converter.py temporalio/converter/init.py tests/test_converter.py
  • direct source validation for public JSONTypeConverterUnhandled import and to_typed_value return annotation
  • direct source validation for a custom JSONTypeConverter with value_to_type

Note: I attempted the focused pytest coverage, but this local checkout cannot run repo pytest without the Temporal Rust bridge/test harness being built. The checkout has an empty sdk-core submodule and this machine does not have cargo available, so CI is the authoritative full test run.

@Lingavasan Lingavasan requested a review from a team as a code owner May 23, 2026 05:20
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 23, 2026

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Unexposed return type of public method

2 participants