Skip to content

chore: add PR template#1045

Merged
chaptersix merged 4 commits into
temporalio:mainfrom
chaptersix:chore/pr-template
May 26, 2026
Merged

chore: add PR template#1045
chaptersix merged 4 commits into
temporalio:mainfrom
chaptersix:chore/pr-template

Conversation

@chaptersix
Copy link
Copy Markdown
Contributor

@chaptersix chaptersix commented May 21, 2026

What changed?

Adds a PR template to guide contributors through the checklist of CLI design principles, help text standards, and testing expectations.

@chaptersix chaptersix marked this pull request as ready for review May 21, 2026 21:47
@chaptersix chaptersix requested a review from a team as a code owner May 21, 2026 21:47
@chaptersix chaptersix requested a review from fretz12 May 21, 2026 21:47
Copy link
Copy Markdown
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I made some suggestions, but nothing blocking as this can always evolve.

Comment thread .github/pull_request_template.md Outdated
Comment thread .github/pull_request_template.md Outdated
Comment thread .github/pull_request_template.md Outdated
Comment thread .github/pull_request_template.md Outdated
Comment thread .github/pull_request_template.md Outdated
Comment thread .github/pull_request_template.md Outdated
Comment thread .github/pull_request_template.md Outdated
Comment thread .github/pull_request_template.md
- Clarify checklist intro and add AI agent tip
- Fix Cloud-only check wording to be less misleading
- Update noun/verb structure item with concrete example
- Add good/bad example for flag naming guideline
- Remove ambiguous "don't reword the command name" item
- Replace "diagnostics" with "warnings" in behavior check
- Add instruction comment to manual tests section
@chaptersix chaptersix merged commit c4061c4 into temporalio:main May 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants