Skip to content

Commit 216b433

Browse files
committed
Name the analyze goldens stdout.json
The file holds the command's stdout, as stdout.txt did; the extension is what makes editors highlight it as JSON. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6XkyWnx7iJFEb8q3AnYps
1 parent df6c041 commit 216b433

37 files changed

Lines changed: 7 additions & 7 deletions

File tree

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ A case is a directory holding the inputs and the expected output. `exec.json`
120120
names the command and its arguments — omit it and the case runs `generate`,
121121
comparing the generated files against the ones committed alongside; give it
122122
`{"command": "analyze", "args": [...]}` and the case compares the command's
123-
stdout against `output.json` (or `stdout.txt` for a command that does not
123+
stdout against `stdout.json` (or `stdout.txt` for a command that does not
124124
print JSON). A case that is expected to fail commits its `stderr.txt`. Regenerate a golden by running the command in its directory and
125125
writing the output back over the committed file.
126126

internal/endtoend/case_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ func parseStderr(t *testing.T, dir, testctx string) []byte {
5252
return nil
5353
}
5454

55-
// parseStdout reads the command's expected output: output.json for a
55+
// parseStdout reads the command's expected output: stdout.json for a
5656
// command that prints JSON, so editors highlight it, otherwise stdout.txt.
5757
func parseStdout(t *testing.T, dir string) []byte {
5858
t.Helper()
59-
for _, name := range []string{"output.json", "stdout.txt"} {
59+
for _, name := range []string{"stdout.json", "stdout.txt"} {
6060
path := filepath.Join(dir, name)
6161
if _, err := os.Stat(path); os.IsNotExist(err) {
6262
continue

internal/endtoend/testdata/analyze_ast/postgresql/output.json renamed to internal/endtoend/testdata/analyze_ast/postgresql/stdout.json

File renamed without changes.

internal/endtoend/testdata/analyze_basic/clickhouse/output.json renamed to internal/endtoend/testdata/analyze_basic/clickhouse/stdout.json

File renamed without changes.

internal/endtoend/testdata/analyze_basic/duckdb/output.json renamed to internal/endtoend/testdata/analyze_basic/duckdb/stdout.json

File renamed without changes.

internal/endtoend/testdata/analyze_basic/googlesql/output.json renamed to internal/endtoend/testdata/analyze_basic/googlesql/stdout.json

File renamed without changes.

internal/endtoend/testdata/analyze_basic/mssql/output.json renamed to internal/endtoend/testdata/analyze_basic/mssql/stdout.json

File renamed without changes.

internal/endtoend/testdata/analyze_basic/mysql/output.json renamed to internal/endtoend/testdata/analyze_basic/mysql/stdout.json

File renamed without changes.

internal/endtoend/testdata/analyze_basic/postgresql/output.json renamed to internal/endtoend/testdata/analyze_basic/postgresql/stdout.json

File renamed without changes.

internal/endtoend/testdata/analyze_basic/sqlite/output.json renamed to internal/endtoend/testdata/analyze_basic/sqlite/stdout.json

File renamed without changes.

0 commit comments

Comments
 (0)