Skip to content

[Enhancement] Unify behavior when a folder is selected #2661

Description

@goran-w
  • When selecting a folder in Local Changes (Show as filesystem tree), the page "Select file to view changes" is displayed.
    • Special-case: when the selected folder has only a single file/item listed beneath it, that file's content is displayed instead. This breaks the pattern and can be a bit confusing to the user. IMHO, it would be better to be consistent and always show the same kind of page for a folder!
  • When selecting a folder in History - Files (for a commit in log-graph), then an empty page is displayed. This is inconsistent with how the filesystem tree behaves in Local Changes. A simple fix for this would be to re-use the same page as in Local Changes, but simply replace its text with "Select file to view contents" (based on some input-param isChangeList or similar).
    • (It also doesn't have the single-file special-case from that other view, which IMHO is a good thing...)
  • NOTE: An alternative solution would be to always display a (new) page "Folder" (+ folder-icon) when a folder is selected.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions