Skip to content

Commit fe34462

Browse files
waleedlatif1claude
andcommitted
fix(selectors): consolidate Notion canonical param pairs into array conditions
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 92e96e8 commit fe34462

File tree

1 file changed

+4
-75
lines changed

1 file changed

+4
-75
lines changed

apps/sim/blocks/blocks/notion.ts

Lines changed: 4 additions & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export const NotionBlock: BlockConfig<NotionResponse> = {
9595
mode: 'basic',
9696
condition: {
9797
field: 'operation',
98-
value: 'notion_read_database',
98+
value: ['notion_read_database', 'notion_query_database', 'notion_add_database_row'],
9999
},
100100
required: true,
101101
},
@@ -108,7 +108,7 @@ export const NotionBlock: BlockConfig<NotionResponse> = {
108108
mode: 'advanced',
109109
condition: {
110110
field: 'operation',
111-
value: 'notion_read_database',
111+
value: ['notion_read_database', 'notion_query_database', 'notion_add_database_row'],
112112
},
113113
required: true,
114114
},
@@ -122,7 +122,7 @@ export const NotionBlock: BlockConfig<NotionResponse> = {
122122
placeholder: 'Select parent page',
123123
dependsOn: ['credential'],
124124
mode: 'basic',
125-
condition: { field: 'operation', value: 'notion_create_page' },
125+
condition: { field: 'operation', value: ['notion_create_page', 'notion_create_database'] },
126126
required: true,
127127
},
128128
{
@@ -132,7 +132,7 @@ export const NotionBlock: BlockConfig<NotionResponse> = {
132132
canonicalParamId: 'parentId',
133133
placeholder: 'ID of parent page',
134134
mode: 'advanced',
135-
condition: { field: 'operation', value: 'notion_create_page' },
135+
condition: { field: 'operation', value: ['notion_create_page', 'notion_create_database'] },
136136
required: true,
137137
},
138138
{
@@ -187,30 +187,6 @@ export const NotionBlock: BlockConfig<NotionResponse> = {
187187
},
188188
},
189189
// Query Database Fields
190-
{
191-
id: 'databaseSelector',
192-
title: 'Database',
193-
type: 'project-selector',
194-
canonicalParamId: 'databaseId',
195-
serviceId: 'notion',
196-
selectorKey: 'notion.databases',
197-
selectorAllowSearch: false,
198-
placeholder: 'Select Notion database',
199-
dependsOn: ['credential'],
200-
mode: 'basic',
201-
condition: { field: 'operation', value: 'notion_query_database' },
202-
required: true,
203-
},
204-
{
205-
id: 'databaseId',
206-
title: 'Database ID',
207-
type: 'short-input',
208-
canonicalParamId: 'databaseId',
209-
placeholder: 'Enter Notion database ID',
210-
mode: 'advanced',
211-
condition: { field: 'operation', value: 'notion_query_database' },
212-
required: true,
213-
},
214190
{
215191
id: 'filter',
216192
title: 'Filter',
@@ -273,29 +249,6 @@ export const NotionBlock: BlockConfig<NotionResponse> = {
273249
condition: { field: 'operation', value: 'notion_search' },
274250
},
275251
// Create Database Fields
276-
{
277-
id: 'parentSelector',
278-
title: 'Parent Page',
279-
type: 'file-selector',
280-
canonicalParamId: 'parentId',
281-
serviceId: 'notion',
282-
selectorKey: 'notion.pages',
283-
placeholder: 'Select parent page',
284-
dependsOn: ['credential'],
285-
mode: 'basic',
286-
condition: { field: 'operation', value: 'notion_create_database' },
287-
required: true,
288-
},
289-
{
290-
id: 'parentId',
291-
title: 'Parent Page ID',
292-
type: 'short-input',
293-
canonicalParamId: 'parentId',
294-
placeholder: 'ID of parent page where database will be created',
295-
mode: 'advanced',
296-
condition: { field: 'operation', value: 'notion_create_database' },
297-
required: true,
298-
},
299252
{
300253
id: 'title',
301254
title: 'Database Title',
@@ -326,30 +279,6 @@ export const NotionBlock: BlockConfig<NotionResponse> = {
326279
},
327280
},
328281
// Add Database Row Fields
329-
{
330-
id: 'databaseSelector',
331-
title: 'Database',
332-
type: 'project-selector',
333-
canonicalParamId: 'databaseId',
334-
serviceId: 'notion',
335-
selectorKey: 'notion.databases',
336-
selectorAllowSearch: false,
337-
placeholder: 'Select Notion database',
338-
dependsOn: ['credential'],
339-
mode: 'basic',
340-
condition: { field: 'operation', value: 'notion_add_database_row' },
341-
required: true,
342-
},
343-
{
344-
id: 'databaseId',
345-
title: 'Database ID',
346-
type: 'short-input',
347-
canonicalParamId: 'databaseId',
348-
placeholder: 'Enter Notion database ID',
349-
mode: 'advanced',
350-
condition: { field: 'operation', value: 'notion_add_database_row' },
351-
required: true,
352-
},
353282
{
354283
id: 'properties',
355284
title: 'Row Properties',

0 commit comments

Comments
 (0)