Skip to content

Commit cefc034

Browse files
j15zclaude
andcommitted
fix(testing): add missing select type to TableColumnType fixture
TableColumnType had also drifted out of sync with COLUMN_TYPES, missing 'select'. It can't import COLUMN_TYPES to derive itself (packages/* can't import apps/*), so it stays hand-maintained — documented in place so the next drift is at least explained. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 875eef5 commit cefc034

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

packages/testing/src/factories/table.factory.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,14 @@ import { generateShortId } from '@sim/utils/id'
22

33
const COLUMN_SUFFIX_ALPHABET = 'abcdefghijklmnopqrstuvwxyz0123456789_'
44

5-
export type TableColumnType = 'string' | 'number' | 'boolean' | 'date' | 'json'
5+
/**
6+
* Mirrors `apps/sim/lib/table/constants.ts`'s `COLUMN_TYPES` and must be kept
7+
* in sync with it by hand — `packages/*` can't import from `apps/*` (see
8+
* `.claude/rules/sim-architecture.md`), so there's no single source of truth
9+
* this can be derived from across the package boundary. This was previously
10+
* missing `select`.
11+
*/
12+
export type TableColumnType = 'string' | 'number' | 'boolean' | 'date' | 'json' | 'select'
613

714
export interface TableColumnFixture {
815
name: string

0 commit comments

Comments
 (0)